New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WiX Toolset build tools to windows-2022
#4419
Comments
Hi @barnson! |
@barnson Thanks for the PR! |
Thanks! |
We are getting the following error when trying to build one of our Wix projects on a 2022 image we built ourselves using the packer script:
|
I found the wix.ca.targets file in the wix toolset's SDK folder, but now it's failing trying to find the wix.targets file, which does not exist in the wix toolset's folder. |
WiX installs its targets files to |
Yep, that worked, thanks for the help! Our Wix project is super old at this point, so that probably explains the issue. |
.wixproj files need multiple changes to support isolated MSBuild. The easiest way to fix them is probably to create new .wixproj files from the templates in the Visual Studio extension for VS2019 or VS2022. |
Why happened this regression in the |
@barnson , @PatrickGrub - this is what I had to change in our main .wixproj file to get the project to build on the VS 2022 agents: |
I could solve it by using vm image "windows-latest. Edit: |
@NateB2 this helped for VS 2019 agents, too. Thanks for this. For anyone else who want copy-paste the changes:
|
Note that removing the |
For all those for whom the file changes are currently too time-consuming or do not work. You can execute the file that @barnson removed in the ci yourself. But it may take 20 minutes. |
@chrpai you can't specify image version unfortunately |
Rats. Is there an ETA on when the new image will be deployed? I'm a WiX / Azure DevOps consultant and my inbox is being lit up by customers with broken builds. |
@chrpai the new images should be available by Thursday next week. We will post an update message. |
For a quick workaround add this powershell to your VS2019 builds. The code is simplified snippets taken from InstallHelpers.ps1 and Install-Wix.ps1, The dependency on the toolset.json is removed and hardcoded to Enterprise edition. function Start-DownloadWithRetry
} function Install-VsixExtension
} Install-VsixExtension -Url https://wixtoolset.gallerycdn.vsassets.io/extensions/wixtoolset/wixtoolsetvisualstudio2019extension/1.0.0.4/1563296438961/Votive2019.vsix -Name Votive2019.vsix -VSversion 2019 |
Hello everyone! We have reverted changes for Windows 2016 and 2019. The pull request has been merged. We will rollout images next week. Thank you for the patience! |
Based on 446bf8d#diff-816219d3c9f30fcc1c40f88ca826c1662bf99eded781c1b419dd2dfb577ae227L480-L481 and behavior I noted in my builds this morning, WiX was removed entirely from the windows-2019 image |
@VonOgre WiX toolset is located under Tools now: https://github.com/actions/virtual-environments/blob/446bf8d222493ea5c155c47024263a72f3aa87dc/images/win/Windows2019-Readme.md?plain=1#L88 |
Does this mean the issue with 2019 missing wix toolset will also be resolved soon without the need of user action - so pipelines will work again? Or must we implement the suggested fix posted above regarding the .wixproj files? |
@MPasadu, you will want to apply those changes to your .wixproj in all cases. Future updates to the tooling will (eventually) deprecate the current syntax. |
Hello everyone! The new Windows2016 and Winndows2019 images should be available now. |
@dibir-magomedsaygitov Thank you! I can confirm that my pipelines are green after disabling my Install Votive 2019 build step. |
@dibir-magomedsaygitov I am still getting an error regarding the wix Toolset is not installed. VmImage 'windows-2019' Please see below error from pipelines. ============================================================================== |
Update: Pipeline is working OK for me now. I have put them back in and now it is working OK |
Windows images were deployed. |
@MaksimZhukov Thanks for fixing VS2019. Where does this leave VS2022? Does it have WiX or not yet? If not yet do we have an ETA? |
@chrpai installation was fixed for Windows 2016 and 2019. Windows 2022 has a WiX toolset installed as well (https://github.com/actions/virtual-environments/blob/050efaf52a756ad291fd5e0d5923d07e913bc34c/images/win/Windows2022-Readme.md?plain=1#L82). |
Can the the windows Images be updated to use wix v3.14? To support .net framework 4.8 capabilities, we need wix 3.14. => https://wixtoolset.org/releases/v3-14-0-712/ it doesn't look like windows-2022 have wix 3.14, which is preventing us from using Azure hosted agents. |
@gep13 👋is it possible to update https://community.chocolatey.org/packages/wixtoolset package to WiX 3.14 per @SenthilSelvaraju request? |
@miketimofeev I can certainly add it to my list of things to do, however, I can't commit to exactly when that might be. |
@miketimofeev actually, looking at the release page, it would seem that the latest production releases are already available: https://wixtoolset.org/releases/ @robmen can you confirm if the production releases have changed? |
The production releases have not changed. We are totally focused on a WiX v4 release by the end of the year. |
We are using private agents as a work around. Do you mind sending an update in this thread when Wix v4 is available in windows images? Thanks. |
One of the huge changes in WiX v4 is that we've done (a lot of) work so that the WiX Toolset is easily installable without out having to be built into the many, many various CI virtual environments. For example, when using a .wixproj in v4, running Our (obvious) goal is to make it trivial to use whichever revision of WiX v4 you want without needing an update from the CI provider. |
That's exciting.!!! Thanks for the brief into the upcoming release. I appreciate it. I am looking forward to the release of Wix v4. |
Tool name
WiX Toolset
Tool license
MS-RL
Add or update?
Desired version
v3.11.2.4516
Approximate size
120MB
Brief description of tool
About the WiX toolset: The WiX toolset lets developers create installers for Windows Installer, the Windows installation engine.
WiX is available in previous generations of VMs but was not included in
windows-2022
, presumably because Visual Studio 2022 isn't yet supported by the WiX Visual Studio extension. However, the WiX Visual Studio extension is only used for in-IDE development and isn't needed to build (from the command line or MSBuild).URL for tool's homepage
https://wixtoolset.org/
Provide a basic test case to validate the tool's functionality.
"%WIX%\bin\candle.exe"
Virtual environments affected
Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
Yes
The text was updated successfully, but these errors were encountered: