Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all OSs] Default Nodejs version will be set to 16 on November, 29 #4446

Closed
7 tasks done
miketimofeev opened this issue Nov 9, 2021 · 6 comments · Fixed by meilisearch/documentation#1322
Closed
7 tasks done

Comments

@miketimofeev
Copy link
Contributor

Breaking changes

We are going to set Nodejs 16 as the default version across all VM images.

Target date

Image deployment is starting on November 29 and will take 3-4 days.

The motivation for the changes

Node.js 16 has moved to Active LTS status and is ready for general use. We would like to provide images with the latest stable updates as default ones.

Possible impact

If your builds depend on the default Nodejs 14 or npm 6 they can be broken.

Virtual environments affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022

Mitigation ways

The recommended way is to pin your workflow to the desired nodejs version using:

@ejntaylor
Copy link

Is there a good place to subscribe to updates like this so we can prepare in advance for it... Or best just to keep an eye on the Issues here in GH? Thanks

@mikhailkoliada
Copy link
Member

All the images are deployed with 16 by default

bors bot added a commit to meilisearch/documentation that referenced this issue Dec 2, 2021
1322: Specify node version in CI jobs r=dichotommy a=bidoubiwa

# Pull Request

## What does this PR do?

Fixes [CI environment that updated to node 16](actions/runner-images#4446) while the documentation is not yet compatible with node 16.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!


Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
@hinchley2018
Copy link

@ejntaylor we subscribed to github releases for this repo so that we are notified in the future

@phun-ky
Copy link

phun-ky commented Dec 10, 2021

Is there a better way to communicate breaking changes like this? Changes like this has to be communicated on the organization level of the consumers of this service, not the individual github users. We are now, again, having breaking builds due to the lack of proper communication regarding changes in Azure.

@miketimofeev
Copy link
Contributor Author

@phun-ky Sorry for the inconvenience. I will raise this issue internally and we will try to figure out possible announcement options for ADO

@phun-ky
Copy link

phun-ky commented Dec 10, 2021

@miketimofeev the issue is a zlib error (isaacs/minizlib#8 (comment)) from npm with the npm pack command. Usually migated by downgrading node and npm, but since we're using your image, that way is not possible.

Pl217 added a commit to UN-OCHA/hpc-cdm that referenced this issue Dec 10, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-cdm that referenced this issue Dec 10, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-cdm that referenced this issue Dec 10, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-api that referenced this issue Dec 10, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-repo-tools that referenced this issue Dec 10, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-cdm that referenced this issue Dec 16, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-api that referenced this issue Dec 16, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-cdm that referenced this issue Dec 29, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-api that referenced this issue Dec 29, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-repo-tools that referenced this issue Dec 29, 2021
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
eronisko added a commit to SlovakNationalGallery/komarch.sk that referenced this issue Jan 13, 2022
eronisko added a commit to SlovakNationalGallery/komarch.sk that referenced this issue Jan 13, 2022
Pl217 added a commit to UN-OCHA/hpc-cdm that referenced this issue Jan 26, 2022
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Pl217 added a commit to UN-OCHA/hpc-api that referenced this issue Jan 27, 2022
Even though Node v16 is the default
actions/runner-images#4446
be explicit about the version needed, because
future updates may break CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants