Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WiX Toolset #9426

Closed
4 of 14 tasks
arixmkii opened this issue Feb 28, 2024 · 6 comments
Closed
4 of 14 tasks

Update WiX Toolset #9426

arixmkii opened this issue Feb 28, 2024 · 6 comments
Labels
Area: Common Tools awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request OS: Windows

Comments

@arixmkii
Copy link

arixmkii commented Feb 28, 2024

Tool name

WiX

Tool license

Microsoft Reciprocal License (MS-RL)

Add or update?

  • Add
  • Update

Desired version

3.14

Approximate size

No response

Brief description of tool

WiX handles MSI installation as you folks most likely know. WiX was recently released v 3.14 to mitigate DLL redirect vulnerability

URL for tool's homepage

https://wixtoolset.org/

Provide a basic test case to validate the tool's functionality.

Platforms where you need the tool

  • Azure DevOps
  • GitHub Actions

Runner images where you need the tool

  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

No response

Tool installation time in runtime

No response

Are you willing to submit a PR?

No response

@arixmkii arixmkii changed the title Update/Add [tool name] Update WiX Toolset Feb 28, 2024
@shamil-mubarakshin
Copy link
Contributor

Hey @arixmkii,
Images with updated wixtoolset are expected to be deployed by the end of next week.

@shamil-mubarakshin shamil-mubarakshin added awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Windows Area: Common Tools and removed needs triage labels Feb 28, 2024
printfn added a commit to printfn/fend that referenced this issue Mar 7, 2024
@dbenzhuser
Copy link

And here I was wondering why my builds that ran fine just yesterday are now failing ...

Anybody else getting these after the update to 3.14?

light.exe : error LGHT0204: ICEM10: The property 'ProductCode' is not allowed in a Merge Module

light.exe : error LGHT0217: Error executing ICE action 'ICE103'. The most common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was not expected by the external UI message logger: "There is a problem with this Windows Installer package. A DLL required for this install to complete could not be run. Contact your support personnel or package vendor.

@mikhailkoliada
Copy link
Member

Deployed!

@dbenzhuser
Copy link

Just in case anybody finds this: Seems to be a bug in VS's mergemodule.cub that got picked up in Wix 3.14 and just never got fixed. Merge modules can be built by suppressing ICE103 and ICEM10.

@chrpai
Copy link

chrpai commented Mar 20, 2024

I've found multiple issues with this change and reported it under #9543

@chrpai
Copy link

chrpai commented Mar 21, 2024

Yes, taking mergemod.cub from 3.11 and copying it to 3.14\bin works around this issue. I also found an issue with the NetFx Extension which can be solved in a similar way. I don't know what other issues might lurk in 3.14 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common Tools awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request OS: Windows
Projects
None yet
Development

No branches or pull requests

5 participants