Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Set the dynamic port range to start at port 49152 and to end at the 65536 (16384 ports) #1442

Merged
merged 4 commits into from Aug 24, 2020

Conversation

al-cheb
Copy link
Contributor

@al-cheb al-cheb commented Aug 19, 2020

Description

After installing VS via script https://github.com/actions/virtual-environments/blob/main/images/win/scripts/Installers/Install-VS.ps1 the dynamic port range is changed to:

Protocol tcp Dynamic Port Range
    vhd: ---------------------------------
    vhd: Start Port      : 1024
    vhd: Number of Ports : 64511

Example https://github.visualstudio.com/virtual-environments/_build/results?buildId=78654&view=logs&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=486c0909-f67d-5748-80b3-bb1d531e7b43 :

Before Visual Studio installation [703]:

==> vhd: Provisioning with powershell script: C:\agent\_work\9\s\images\win/scripts/Installers/Install-VS.ps1
    vhd: Display ports
    vhd:
    vhd: Protocol tcp Dynamic Port Range
    vhd: ---------------------------------
    vhd: Start Port      : 49152
    vhd: Number of Ports : 16384

After [825]:

    vhd: Display ports
    vhd:
    vhd: Protocol tcp Dynamic Port Range
    vhd: ---------------------------------
    vhd: Start Port      : 1024
    vhd: Number of Ports : 64511
    vhd:

Related issue:

https://github.com/actions/virtual-environments-internal/issues/996

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@al-cheb al-cheb requested review from chkimes and a team August 19, 2020 15:51
@maxim-lobanov maxim-lobanov merged commit ba17c75 into actions:main Aug 24, 2020
@al-cheb al-cheb deleted the al-cheb/set-dynamic-range-port branch August 24, 2020 06:44
johnmckenna pushed a commit to whitehatsec/virtual-environments that referenced this pull request Dec 3, 2020
…d at the 65536 (16384 ports) (actions#1442)

* set the dynamic port range

* update pester test

* update context about VS installer

* update dynamicports pester test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants