Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ubuntu] Add Firefox for 22.04 from PPA source #6528

Merged
merged 1 commit into from
Nov 26, 2022
Merged

[Ubuntu] Add Firefox for 22.04 from PPA source #6528

merged 1 commit into from
Nov 26, 2022

Conversation

Alexey-Ayupov
Copy link
Collaborator

Description

  • Add Firefox browser to ubuntu 22.04 from PPA source.
  • Update browsers test to be able to validate Firefox installation on Ubuntu 22.04
  • Include Firefox on Ubuntu 22.04 in the Software Report

Related issue:

https://github.com/actions/runner-images-internal/issues/4573

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@mikhailkoliada
Copy link
Member

/azp run ubuntu2204

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

al-cheb
al-cheb reviewed Nov 8, 2022
View reviewed changes
images/linux/scripts/installers/firefox.sh Outdated
@@ -6,6 +6,13 @@

# Source the helpers for use with the script
source $HELPER_SCRIPTS/install.sh
source $HELPER_SCRIPTS/os.sh

# Update source (PPA) for Firefox for Ubuntu22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use this ppa for all Ubuntu images and remove the condition?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needed to be checked. I have tested and it seems to be working on all Ubuntu images. The condition was removed, and firefox will be installed from the PPA source for all images.

@Alexey-Ayupov Alexey-Ayupov force-pushed the ubuntu2204-add-firefox branch 3 times, most recently from 92218d3 to 57a9820 Compare November 9, 2022 06:59
@mikhailkoliada
Copy link
Member

/azp run ubuntu1804,ubuntu2004,ubuntu2204

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mikhailkoliada
Copy link
Member

/azp run ubuntu1804,ubuntu2004,ubuntu2204

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

al-cheb
al-cheb reviewed Nov 9, 2022
View reviewed changes
images/linux/scripts/installers/firefox.sh Outdated
# Install Firefox
add-apt-repository $FIREFOX_REPO -y
apt-get update
apt-get install -y firefox
Copy link
Contributor

@al-cheb al-cheb Nov 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu’s official repository has version number 1:1snap1-0ubuntu2, which is always higher than the PPA package version. We should think how to override it like (sudo apt install --target-release 'o=LP-PPA-mozillateam' firefox) and not to break anybody who uses apt-get update during builds.

@Alexey-Ayupov Alexey-Ayupov force-pushed the ubuntu2204-add-firefox branch 3 times, most recently from aee5212 to ce27cde Compare November 14, 2022 15:22
@mikhailkoliada
Copy link
Member

/azp run ubuntu2204

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qhanam qhanam mentioned this pull request Nov 21, 2022
Merged
@fgebhart fgebhart mentioned this pull request Nov 24, 2022
Merged
@noxone noxone mentioned this pull request Nov 25, 2022
Closed
@yonta yonta mentioned this pull request Nov 25, 2022
Closed
@mikhailkoliada mikhailkoliada merged commit 5dd62e7 into actions:main Nov 26, 2022
@nmanu1 nmanu1 mentioned this pull request Dec 1, 2022
Merged
@josephlr josephlr mentioned this pull request Feb 9, 2023
Merged
@Alexey-Ayupov Alexey-Ayupov deleted the ubuntu2204-add-firefox branch April 5, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-cheb al-cheb al-cheb left review comments

@erik-bershel erik-bershel erik-bershel left review comments

@mikhailkoliada mikhailkoliada mikhailkoliada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Alexey-Ayupov @mikhailkoliada @al-cheb @erik-bershel