[macOS] Remove Haskell and Cargo packages #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpolikarpov-akvelon
approved these changes
Nov 10, 2023
| $rustPackages.AddToolVersion("Cargo-audit", $(Get-Cargoaudit)) | ||
| $rustPackages.AddToolVersion("Cargo-outdated", $(Get-Cargooutdated)) | ||
| $rustPackages.AddToolVersion("Cbindgen", $(Get-Cbindgen)) | ||
| if ((-not $os.IsVentura) -and (-not $os.IsVenturaArm64)) { |
There was a problem hiding this comment.
Nested condition might be a bit harder to understand from my point of view. What do you think of moving it to outer level? Also what do you think of replacing it with positive condition is_BigSur || is_Monterey like you have in rust.sh?
Alexey-Ayupov
force-pushed
the
macos-remove-apps
branch
2 times, most recently
from
4b07bb2
to
54d6e13
Compare
Alexey-Ayupov
force-pushed
the
macos-remove-apps
branch
from
54d6e13
to
3c70261
Compare
mikhailkoliada
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Haskell and Cargo packages from macOS 13 and macOS 14 images
Related issue:
Check list