Composite: Step Outputs are not available when in nested composite actions

[antdking]

Describe the bug
When a workflow uses a composite action, the post steps of actions within the Composite have their inputs evaluated with the Steps context.

However when the same Composite Action is nested in another Composite Action, the Steps context is lost for the Post steps.

Our usecase for wanting this is to cache dependencies effectively without polluting our Workflows.

To Reproduce
workflow uses a composite that uses a composite.

Reproduced here: https://github.com/antdking/composite-post-step-outputs-demo, specifically this workflow
This run includes debug output: https://github.com/antdking/composite-post-step-outputs-demo/actions/runs/2710027823

Expected behavior
Able to use Post steps for Composite Actions that are used by other Composite Actions.

Runner Version and Platform

Hosted runner, affects all Platforms

What's not working?

Please include error messages and screenshots.

When executing the Post Run for the wrapping composite:

 ##[debug]Evaluating condition for step: 'Post wrapperComposite'
##[debug]Evaluating: always()
##[debug]Evaluating always:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Post wrapperComposite
##[debug]Loading inputs
##[debug]Loading env
Post job cleanup.
##[debug]Evaluating condition for step: 'run'
##[debug]Evaluating: always()
##[debug]Evaluating always:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: run
##[debug]Loading inputs
##[debug]Evaluating: steps.setter.outputs.some-val
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating steps:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'setter'
##[debug]....=> null
##[debug]..=> null
##[debug]=> null
##[debug]Result: null
##[debug]Loading env
Post job cleanup.
value received: 
Error: value: '' is not 'foo'
##[debug]Node Action run completed with exit code 1
##[debug]Finished: run
##[debug]Finishing: Post wrapperComposite

the setter Step seems to be missing when evaluating the post steps.

Runner and Worker's Diagnostic Logs

n/a

[Sytten]

I am also experiencing a similar issue.
Even most of the inputs are not available in the context of post hook for nested composite actions, not just step outputs.

See https://github.community/t/inputs-passed-to-action-are-blank-in-post-script/262930
Minimal repro: https://github.com/mxxk/gh-actions-issue-post-inputs-missing

[ChristopherHX]

This issue is only affecting composite actions called like uses: ./path/to/action, in this case the runner squashes all post steps into the outer composite action. The call flow of composite actions is hard to follow.

Caused by the ExecutionContext.Id parameter, Action.Id seems to provide better choice

runner/src/Runner.Worker/ActionRunner.cs

Line 94 in 813af29

var prepareResult = await actionManager.PrepareActionsAsync(ExecutionContext, compositeHandlerData.Steps, ExecutionContext.Id);

You can avoid this bug by referenceing it remotely like uses: <myorg>/<myrepo></path/to/action>@<branch/tag/sha>

Does github actions have enough integration / end to end Tests? At least they are not publicy available

[antdking]

You can avoid this bug by referenceing it remotely like uses: <myorg>/<myrepo></path/to/action>@<branch/tag/sha>

Does github actions have enough integration / end to end Tests? At least they are not publicy available

The proposed workaround won't work, as there isn't a way to pass the current git ref as a parameter (no interpolation in uses).

---

edit: clarified that I'm referring to the uses workaround, and not the proposed code fix. Sorry!

[Sytten]

No progress on this? It is kind of an important bug...

[redsun82]

I just hit this bug as well

[cognitiaclaeves]

This is a pretty nasty issue when you're trying to rely on a nested action (to get around github's lack of retry) and have no idea why it is failing.

[mkellerman-relativity]

Bump

[Sophie1142]

Upvoting this issue

[Yehonal]

news here?

[haochenx]

update: please see #2009 (comment) and disregard this comment

(original comment)

seems like a fix is coming together with https://github.com//pull/1803? is there an estimation for #1803 to be merged?

it seems that there's already a fix in nikola-jokic@69f84e9
is it possible to get it shipped first without waiting for other changes that #1803 might bring?

[ChristopherHX]

No nikola-jokic@69f84e9 is not a fix for the bug described here, the commit message had a typo and was not related to this issue.

[ChristopherHX]

Hopefully someone can review: #2710, I provide a more meaningful reproduction workflow:

To reproduce run: https://github.com/ChristopherHX/local-post-steps-bug

See https://github.com/ChristopherHX/local-post-steps-bug/actions/runs/5661561768/job/15339706765

Post job cleanup.
Post job cleanup.
"{\n  \"depth2\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"
Post job cleanup.
"{\n  \"depth2\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"
Post job cleanup.
"{\n  \"depth2\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"
Post job cleanup.
"{\n  \"depth2\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"

• The first post step executes just fine
• The second steps context should only contain depth3
• The third steps context should only contain depth4
• The fourth steps context should be empty

After applying this change we have

[.github/workflows/main.yml / local-post-steps-bug] Running: Post Run /./depth1
| Post job cleanup.
| Post job cleanup.
| "{\n  \"depth2\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"
| Post job cleanup.
| Post job cleanup.
| "{\n  \"depth3\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"
| Post job cleanup.
| Post job cleanup.
| "{\n  \"depth4\": {\n    \"outputs\": {},\n    \"outcome\": \"success\",\n    \"conclusion\": \"success\"\n  }\n}"
| Post job cleanup.
| Post job cleanup.
| "{}"
[.github/workflows/main.yml / local-post-steps-bug] Succeeded: Post Run /./depth1

The difference to the OP is, you can actually see that the wrong steps context has been provided by actions/runner and after the fix it have the expected values like in nested remote composite actions.

[Sytten]

@sethrylan Could we get some kind of response from the dev team at GitHub for this issue. It is pretty bad and the fix is a one liner...

[keradus]

For those who stumbled on using inputs or outputs for composite GitHub Actions, I found using $GITHUB_ENV to be a viable workaround.

You may find a working example in PHP-CS-Fixer/PHP-CS-Fixer#7415 .
(And also a lot of debugging in keradus/PHP-CS-Fixer#36 .)

Example snippet

name: "Install composer deps"

inputs:
  flags:
    description: 'Composer flags'
    required: false

runs:
  using: "composite"
  steps:
    # Warning!
    # Use $GITHUB_ENV instead of $GITHUB_OUTPUT.
    #
    # The actions/cache is, on calling it in this composite action, reading the cache,
    # and then also registering a shutdown function for whole workflow, to write the cache afterwards.
    #
    # That registered shutdown function is _NOT_ having access to inputs.* nor steps.*.outputs for
    # `path` parameter, which is evaluated on both stages (read and write), yet `key` parameters
    # are evaluated on start only and are not affected by this issue.
    #
    # Unfortunately, when the issue is faced, it does not break the build, simply raising a warning
    # and completing the build successuflly, yet without storing the cache:
    # > Warning: Input required and not supplied: path

    - name: Get Composer cache params
      shell: bash
      run: |
        echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
        echo "COMPOSER_CACHE_PHP=$(php -r 'echo PHP_VERSION;')" >> $GITHUB_ENV

    - name: Cache Composer dependencies
      uses: actions/cache@v3
      with:
        path: ${{ env.COMPOSER_CACHE_DIR }}
        key: Composer-${{ runner.os }}-${{ env.COMPOSER_CACHE_PHP }}-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
        restore-keys: |
          Composer-${{ runner.os }}-${{ env.COMPOSER_CACHE_PHP }}-${{ hashFiles('**/composer.json') }}-
          Composer-${{ runner.os }}-${{ env.COMPOSER_CACHE_PHP }}-
          Composer-${{ runner.os }}-

    - name: Install dependencies
      uses: nick-invision/retry@v2
      with:
        timeout_minutes: 5
        max_attempts: 5
        retry_wait_seconds: 30
        # `--no-scripts` to avoid side-effects (e.g. installing dev-tools for all jobs on CI level),
        # all executed scripts should be explicit and run only when needed.
        command: composer update --optimize-autoloader --no-interaction --no-progress --no-scripts ${{ inputs.flags }}

    - name: Show versions of packages
      shell: bash
      run: composer info -D