-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on.pull_request.paths-ignore are not respected correctly #2324
Comments
Can confirm the bug |
Confirmed when trying this Github suggested solution in the troubleshooting docs: |
I also confirm this bug. |
actions/runner#2324 Signed-off-by: Oz Tiram <oz@spectrocloud.com>
actions/runner#2324 Signed-off-by: Oz Tiram <oz@spectrocloud.com>
* 📖 Align kairos versions in the docs Partial fix for #1049. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix build and server scripts to work system hugo This PR change the detection of hugo to check if it is also found globally (e.g. installed with system's package manager), so there is no need to download and compile hugo locally. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Add parametrized shortcode The version is now read from config.toml, so the release manager has to update only one file everytime we release a new version. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 📖 add paramerized shortcode for k3s Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Don't build images if only docs have changed Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Disable linting go when only docs have changed Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Disable unit-test if only docs changed Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix syntax for exclusion on workflow files Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 another attempt to disable running on docs change only Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 disable lint from running on docs changes Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 test change in docs Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Work around github bug actions/runner#2324 Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix lint.yml syntax Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Disable running unit-tests on docs changes Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 artificial change, test github ci Signed-off-by: Oz Tiram <oz@spectrocloud.com> --------- Signed-off-by: Oz Tiram <oz@spectrocloud.com>
* 📖 Align kairos versions in the docs Partial fix for #1049. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix build and server scripts to work system hugo This PR change the detection of hugo to check if it is also found globally (e.g. installed with system's package manager), so there is no need to download and compile hugo locally. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Add parametrized shortcode The version is now read from config.toml, so the release manager has to update only one file everytime we release a new version. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 📖 add paramerized shortcode for k3s Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Don't build images if only docs have changed Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Disable linting go when only docs have changed Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Disable unit-test if only docs changed Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix syntax for exclusion on workflow files Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 another attempt to disable running on docs change only Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 disable lint from running on docs changes Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 test change in docs Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Work around github bug actions/runner#2324 Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix lint.yml syntax Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Disable running unit-tests on docs changes Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 artificial change, test github ci Signed-off-by: Oz Tiram <oz@spectrocloud.com> --------- Signed-off-by: Oz Tiram <oz@spectrocloud.com>
I can also confirm the bug: Workflow: https://github.com/zdenko-kovac/testing/blob/main/.github/workflows/testPR.yaml where:
|
It's been half a year, any news on this? |
as a work around you can make :
|
Is there an update on this issue? Has anyone developed a workaround? |
…in build triggers
It seems |
@ilyesAj's workaround to negate pull_request:
paths:
- '**'
- '!docs/**'
- '.github/**' |
…in build triggers
Also, I have a similar issue in my project. on: |
According to this explanation https://github.com/orgs/community/discussions/25161#discussioncomment-3246673 this "bug" is by design. Apparently when we make the Although understandable, I think what we're missing here is a different implementation of the
Perhaps the |
Since this is not working might as well just check the docs all the time. See actions/runner#2324.
Since this is not working might as well just check the docs all the time. See actions/runner#2324.
I have a similar issue. I have defined a workflow with the following:
When I push a change of the yaml that contains this code it doesn't execute. This is expected. Then I made a change to |
Describe the bug
According to the documentation we can use
paths-ignore
in the same way forpull_request
events as we can do forpush
events on.<push|pull_request|pull_request_target>.<paths|paths-ignore>.However, if we define a workflow like the following, the behavior differs:
Although it seems to be working at the beginning when I (1) created a pr, (2) pushed a change on
README.md
and (3) nothing triggered, the behavior changed as soon as one commit of the pr references a file outside of thepaths-ignore
list.After a change to a file outside of the
paths-ignore
list, all following commits trigger the workflow.Someone else mentioned a problem here as well: #545 (comment)
To Reproduce
You can find a minimal example here: https://github.com/GRBurst/pull_requests.paths
Steps to reproduce the behavior:
paths-ignore
declarationExpected behavior
I expect that the conditions to run the actions only take the last commit into account.
So if I have commit that changes a file outside the path definition, it triggers the workflow.
If a following commit does only changes to files declared in the
paths-ignore
list, the workflow should not trigger.Runner Version and Platform
Version of your runner?
-> 2.299.1
OS of the machine running the runner? OSX/Windows/Linux/...
-> Ubuntu, 22.04.1, LTS
The text was updated successfully, but these errors were encountered: