-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxies with port 80 are stripped of their port #759
Comments
…#760) * Fixes actions#759 doesn't change proxy environment variables * Update RunnerWebProxy.cs * Update RunnerWebProxyL0.cs Co-authored-by: Tingluo Huang <tingluohuang@github.com>
@JasonLaquaTR Looks like its still happening with v2.294.0. We have a few self-hosted runner pods running on GKE. We are behind a corporate proxy, but the proxy still changes to 1080.
Do I need to do something at my end to resolve this? |
Also running into this same issue as of today with version v2.308. Logs when running --check:
|
Describe the bug
Proxies are stripped of their port if it is 80. This causes anything that uses libcurl to fail because it's default proxy port is 1080.
To Reproduce
Steps to reproduce the behavior:
https_proxy=http://proxy:80
)Related Issue: actions/checkout#216
Expected behavior
Keep port 80 as a part of the proxy environment variable
Runner Version and Platform
Version of your runner?
2.273.5
OS of the machine running the runner? OSX/Windows/Linux/...
OSX and Linux
What's not working?
Environment variable is being stripped of proxy port
Expected
Actual
Job Log Output
If applicable, include the relevant part of the job / step log output here. All sensitive information should already be masked out, but please double-check before pasting here.
Code causing problem
RunnerWebProxy.cs:72-130
The text was updated successfully, but these errors were encountered: