remove additional fields on warning/error command issues #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakale
reviewed
Oct 21, 2019
Comment on lines
-488
to
-491
| foreach (var property in command.Properties) | ||
| { | ||
| issue.Data[property.Key] = property.Value; | ||
| } |
There was a problem hiding this comment.
Are there any other properties in command here that arent given by the user and would be lost?
Otherwise lgtm
There was a problem hiding this comment.
We write log line number but otherwise we don't want to pass anything else along.
See the addissue code below
runner/src/Runner.Worker/ExecutionContext.cs
Line 467 in 0dca481
juliobbv
approved these changes
Oct 21, 2019
thboop
changed the title
thboop
added a commit
that referenced
this pull request
Oct 28, 2019
thboop
added a commit
that referenced
this pull request
Oct 28, 2019
thboop
added a commit
that referenced
this pull request
Oct 28, 2019
* Update to Version 2.160.0 (#144) * Revert "remove issue generation on warning/error commands (#137)" (#147) * Revert "remove issue generation on warning/error commands (#137)" This reverts commit 53da198. * Updated Release notes * Users/thboop/port directory changes (#152) * Clear action cache for local runner * update release notes for actions directory cache changes
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Update to Version 2.160.0 (actions#144) * Revert "remove issue generation on warning/error commands (actions#137)" (actions#147) * Revert "remove issue generation on warning/error commands (actions#137)" This reverts commit 53da198. * Updated Release notes * Users/thboop/port directory changes (actions#152) * Clear action cache for local runner * update release notes for actions directory cache changes
volker-raschek
pushed a commit
to dedalus-cis4u/github-runner-role
that referenced
this pull request
Jul 25, 2022
…mit-action-3.x Update pre-commit/action action to v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the ability for a user to pass through fields to the issue object. We still populate the
logFileLineNumberfield, but users should not be able to manually set other fields using these commands. Eventually they will be pushed towards using the add-annotation field for that behavior.https://github.com/github/pe-actions-runtime/issues/148