Add masks for multiline secrets from ::add-mask::
#1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
reviewed
Nov 30, 2021
| @@ -381,6 +381,13 @@ public void ProcessCommand(IExecutionContext context, string line, ActionCommand | |||
|
|
|||
| HostContext.SecretMasker.AddValue(command.Data); | |||
| Trace.Info($"Add new secret mask with length of {command.Data.Length}"); | |||
|
|
|||
| // Also add each individual line. Typically individual lines are processed from STDOUT of child processes. | |||
| var split = command.Data.Split(new[] { '\r', '\n' }, StringSplitOptions.RemoveEmptyEntries); | |||
There was a problem hiding this comment.
Should we also do StringSplitOptions.TrimEntries so we can avoid trimming each item?
There was a problem hiding this comment.
TrimEntries is new in dotnet 5+, i am going to merge the dotnet 6 PR and then add this.
thboop
reviewed
Nov 30, 2021
TingluoHuang
force-pushed
the
users/tihuang/addmaskml
branch
from
19000da
to
14828bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the runner gets a secret coming from the service as part of the job message, if the secret has multiline, the runner will break the multiline and add a secret masker to each line.
However, we don't have the same logic when an action or step tries to register a new secret masker with
::add-mask::.We should copy the logic and do the same thing with
::add-mask::