updated systemd svc.sh to accept custom service file #1612
Conversation
| arg_2=${2} | ||
| SVC_RUN_AS_USER= | ||
|
|
||
| SCRIPT_NAME=$0 |
There was a problem hiding this comment.
Can we just read from an environment variable and overwrite TEMPLATE_PATH based on that env?
Then we don't need to change the rest of the svc.sh template file, also, we probably want to make same change to darwin.svc.sh.template as well.
There was a problem hiding this comment.
Sure, but then we would have to rely on users remembering that they set the path. But regardless, by using flags, it is more explicit that you want to provide your own template, and it is nice for documentation purposes.
Also, I guess it is more convenient to provide in the command you are starting a service your template than exporting or setting env var and then running it. Let's say I exported a variable to run my template, and I made a mistake. Now, to run the default svc config, I must unset the TEMPLATE_PATH env variable since it would be used again on the next run. With this, I would just run the same command without the flag.
There was a problem hiding this comment.
svc.sh is used when you install/uninstall/start/top the service, but the TEMPLATE_PATH is only used during install.
I don't think we want the customer to install using 1 template and start the service as a different template.
Also, I am trying to minimize the change as much as possible.
There was a problem hiding this comment.
Sure, we can do it that way then. I will revert to the previous state and add fix it that way 😊
nikola-jokic
force-pushed
the
nikola-jokic/feature/1367
branch
from
c89e16c
to
9db684b
Compare
nikola-jokic
force-pushed
the
nikola-jokic/feature/1367
branch
from
9db684b
to
6dacf4e
Compare
| if [[ $IS_CUSTOM_TEMPLATE = 0 ]]; then | ||
| failed "Must run from runner root or install is corrupt" | ||
| else | ||
| failed "Service file at '$GITHUB_ACTIONS_RUNNER_SERVICE_TEMPLATE' using GITHUB_ACTIONS_RUNNER_SERVICE_TEMPLATE env variable not found" |
| if [[ $IS_CUSTOM_TEMPLATE = 0 ]]; then | ||
| failed "Must run from runner root or install is corrupt" | ||
| else | ||
| failed "Service file at '$GITHUB_ACTIONS_RUNNER_SERVICE_TEMPLATE' using GITHUB_ACTIONS_RUNNER_SERVICE_TEMPLATE env variable not found" |
nikola-jokic
force-pushed
the
nikola-jokic/feature/1367
branch
from
6dacf4e
to
3c3cb3b
Compare
|
Thanks, @TingluoHuang 😊 |
Related Issue: #1367