Lets allow up to 150 characters for services on linux/mac #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps support users that use self hosted runners with very long runner/repository names to avoid collisions
Why 150?
Filenames in linux/mac are max of 255 characters, systemd is limited to 255 characters for the service name as well. While we could go all the way there, doubling the length from ~80 to ~150 should be plenty because Runner names can only be 64 characters in length.
So after this change on linux/mac we should only trim the service name if the repository + org name exceeds 70 characters. That isn't a huge deal, as ~64 characters of runner name and 70 characters of org+repository should be unique enough where there are no collisions.
We can't do this on windows, as windows services have max name lengths that are very low, which is why we added this limit in the first place.
Fixing: #730