Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for Container Hooks #1891

Merged
merged 9 commits into from Jun 10, 2022
Merged

Add ADR for Container Hooks #1891

merged 9 commits into from Jun 10, 2022

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented May 12, 2022

This ADR details expanding the Job Hook concept to create container hooks that you can use to invoke containers in your preferred way.

Rendered

@thboop thboop requested a review from a team as a code owner May 12, 2022 20:03
@ruvceskistefan
Copy link
Collaborator

Maybe we should add one sentence about location of response file (_temp/_hook_responses) in the section Writing responses to a file

thboop and others added 6 commits June 10, 2022 09:30
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com>
Copy link
Collaborator

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop thboop merged commit 0d1e6fd into main Jun 10, 2022
@thboop thboop deleted the thboop/ContainerHookADR branch June 10, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants