Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the auth challenge 401 to be verbose trace. #2021

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

TingluoHuang
Copy link
Member

When the runner's OAuth token expired and needs a refresh, we log the following warning to the runner diag log.

[2022-07-25 17:34:28Z WARN GitHubActionsService] Authentication failed on first request with status code 401.
WWW-Authenticate: Bearer
Strict-Transport-Security: max-age=2592000
X-TFS-ProcessId: 994a3e77-7bca-4c4c-81e7-e72c37958c93
ActivityId: 74581e5a-cc7c-44c1-b42b-16ffab259bae
X-TFS-Session: 3865f3e2-07e8-4776-9ab5-bf3879b101be
X-VSS-E2EID: ccfcd2f9-2720-4519-a1e9-36405a46c125
X-VSS-SenderDeploymentId: 6bfa0b85-0342-b826-1c9f-bc636d8425af
X-TFS-ServiceError: The+user+%27System%3aPublicAccess%3baaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa%27+is+not+authorized+to+access+this+resource.
X-VSS-S2STargetService: 0000005A-0000-8888-8000-000000000000/visualstudio.com
X-Cache: CONFIG_NOCACHE
X-MSEdge-Ref: Ref A: CB6CE181CB5F4B41ACF055B51FB17F6C Ref B: ASHEDGE1308 Ref C: 2022-07-25T17:34:28Z
Date: Mon, 25 Jul 2022 17:34:28 GMT
Transfer-Encoding: chunked

This is not helpful to our customers other than creating confusion to make them think the runner is experiencing auth issue.

I am moving the particular trace into verbose from warning to avoid confusion.

@TingluoHuang TingluoHuang requested a review from a team as a code owner July 25, 2022 18:01
Copy link
Contributor

@cory-miller cory-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit 72e2107 into main Jul 25, 2022
@TingluoHuang TingluoHuang deleted the users/tihuang/verbose401 branch July 25, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants