secrets context #22
Merged
secrets context #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Jun 7, 2019
| @@ -481,16 +481,10 @@ public void InitializeJob(Pipelines.AgentJobRequestMessage message, Cancellation | |||
| // Environment variables shared across all actions | |||
| EnvironmentVariables = new Dictionary<string, string>(VarUtil.EnvironmentVariableKeyComparer); | |||
|
|
|||
| // Expression values | |||
There was a problem hiding this comment.
this just moved down a little
ericsciple
commented
Jun 7, 2019
| @@ -186,6 +187,19 @@ public bool TryGetValue(string name, out string val) | |||
| _trace.Verbose($"Get '{name}' (not found)"); | |||
| return false; | |||
| } | |||
|
|
|||
| public DictionaryContextData ToSecretsContext() | |||
There was a problem hiding this comment.
Variables is useful infra, we might as well make use of this class to add useful functions :)
ericsciple
commented
Jun 7, 2019
| if (contextData?.Count > 0) | ||
| { | ||
| foreach (var pair in contextData) | ||
| { | ||
| result.ExpressionValues[pair.Key] = pair.Value; | ||
| } | ||
| } | ||
|
|
||
| // Compat for new agent against old server |
There was a problem hiding this comment.
I've been meaning to add this so we don't hit the future-agent-old-server compat problem again :)
|
LGTM |
volker-raschek
pushed a commit
to dedalus-cis4u/github-runner-role
that referenced
this pull request
Jul 25, 2022
Develop to master
jsoref
pushed a commit
to jsoref/actions-runner
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.