Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDE0090 lints #2211

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix IDE0090 lints #2211

merged 1 commit into from
Oct 18, 2022

Conversation

cory-miller
Copy link
Contributor

@cory-miller cory-miller commented Oct 17, 2022

We've got over 2k lints according to my OmniSharp VSCode plugin. This fixes IDE0090 specifically.

@cory-miller cory-miller requested a review from a team as a code owner October 17, 2022 19:29
@cory-miller cory-miller changed the title Fix IDE0090 Fix IDE0090 lints Oct 17, 2022
@cory-miller cory-miller merged commit b87b4aa into main Oct 18, 2022
@cory-miller cory-miller deleted the users/cory-miller/IDE0090 branch October 18, 2022 14:54
@@ -26,7 +26,7 @@ public sealed class CommandSettings
};

// Valid flags and args for specific command - key: command, value: array of valid flags and args
private readonly Dictionary<string, string[]> validOptions = new Dictionary<string, string[]>
private readonly Dictionary<string, string[]> validOptions = new()
{
// Valid configure flags and args
[Constants.Runner.CommandLine.Commands.Configure] =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@@ -137,7 +137,7 @@ public CommandSettings(IHostContext context, string[] args)
// Validate commandline parser result
public List<string> Validate()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nikola-jokic pushed a commit to nikola-jokic/runner that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants