Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

send annotations to run-service #2574

Merged
merged 8 commits into from
May 1, 2023

Conversation

yaananth
Copy link
Contributor

@yaananth yaananth commented Apr 28, 2023

Closes https://github.com/github/actions-service-team/issues/3684

Highlight of changes for runservice interaction:

  • Complete job now takes annotations
  • Step results now also store annotations

See corresponding run service PR at https://github.com/github/actions-run-service/pull/580, which shows the screenshot of things working with this PR 馃帀

@yaananth yaananth marked this pull request as ready for review April 28, 2023 19:44
@yaananth yaananth requested a review from a team as a code owner April 28, 2023 19:44
Copy link

@AbsolytnaiaLove AbsolytnaiaLove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@AbsolytnaiaLove AbsolytnaiaLove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@AbsolytnaiaLove AbsolytnaiaLove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaananth yaananth requested a review from TingluoHuang May 1, 2023 11:36
@TingluoHuang TingluoHuang merged commit 896152d into actions:main May 1, 2023
10 checks passed
nikola-jokic pushed a commit to nikola-jokic/runner that referenced this pull request May 12, 2023
* send annotations to run-service

* skip message deletion

* actually don't skip deletion

* enum as numbers

* fix enum

* linting

* remove unncessary file

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants