Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ImageOS environment variable in runner images #2878

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

int128
Copy link
Contributor

@int128 int128 commented Sep 24, 2023

ImageOS environment variable is provided in GitHub-hosted runners. It would be nice if it is provided in the self-hosted runner images as well, because some actions such as ruby/setup-ruby depend on it.

See also the following issues:

@int128 int128 requested a review from a team as a code owner September 24, 2023 07:11
@int128
Copy link
Contributor Author

int128 commented Nov 11, 2023

@Link- @nikola-jokic @TingluoHuang
I'd like to ask the maintainers to review this change. If an issue is needed, I will write it.

Copy link
Contributor

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay and thank you for the PR!

@nikola-jokic nikola-jokic merged commit 8a25302 into actions:main Nov 23, 2023
10 checks passed
@int128 int128 deleted the patch-1 branch November 27, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants