Mark job as failed on worker crash. #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokesh755
approved these changes
Nov 27, 2023
TingluoHuang
force-pushed
the
users/tihuang/fix
branch
from
3c3d210
to
f164740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
LogWorkerProcessUnhandledExceptionmethod (called when the worker process crashed) inJobDispatcher.csto add a new condition. If feature flagDistributedTask.MarkJobAsFailedOnWorkerCrashistrue, the job is marked as failed and completed.Main change:
src/Runner.Listener/JobDispatcher.cs: Added a new condition to theLogWorkerProcessUnhandledExceptionmethod to check ifDistributedTask.MarkJobAsFailedOnWorkerCrashistrue. If so, the job is marked as failed and completed.Without mark the job as completed, the service will try to infer the job results from several different conditions, and those can be wrong.
Job is marked as failed when the worker crash with this change.
Fixing:
https://github.com/github/c2c-actions-support/issues/3078
https://github.com/github/c2c-actions-support/issues/3028