consume new expressions and object templating libraries #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Jul 16, 2019
|
|
||
| result.Value = tree.Evaluate<bool>(trace: expressionTrace, secretMasker: HostContext.SecretMasker, state: executionContext, options: evaluationOptions); | ||
| var expressionResult = tree.Evaluate(expressionTrace, HostContext.SecretMasker, state: executionContext, options: null); | ||
| result.Value = expressionResult.IsTruthy; |
There was a problem hiding this comment.
Evaluate always returns an EvaluationResult, so check IsTruthy now
ericsciple
force-pushed
the
users/ersciple/m154type
branch
from
9be046c
to
9784ab6
Compare
ericsciple
force-pushed
the
users/ersciple/m154type
branch
from
9784ab6
to
f17665f
Compare
volker-raschek
pushed a commit
to dedalus-cis4u/github-runner-role
that referenced
this pull request
Jul 25, 2022
Installation idempotence fix
jsoref
pushed a commit
to jsoref/actions-runner
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.