Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an env var to point to an Actions Service dev instance #468

Merged
merged 3 commits into from
May 11, 2020
Merged

Use an env var to point to an Actions Service dev instance #468

merged 3 commits into from
May 11, 2020

Conversation

brcrista
Copy link
Contributor

@brcrista brcrista commented May 6, 2020

When running Actions Service L2 tests against GHES, the instance won't have a codedev.ms URL. This adds the ability to specify the URL through the USE_DEV_ACTIONS_SERVICE_URL environment variable.

Unless someone wants to name their GHES instance codedev.ms, let's leave the old backdoor there for compat.

Testing

@brcrista brcrista requested a review from TingluoHuang May 6, 2020 19:25
We'll still have to pass the URL on the command line
@brcrista brcrista merged commit 09cf59c into actions:master May 11, 2020
@brcrista brcrista deleted the brcrista/actions-service-dev-url branch May 11, 2020 21:22
TingluoHuang pushed a commit that referenced this pull request May 12, 2020
* Use an environment variable for the testing backdoor

* Make the env var a boolean

We'll still have to pass the URL on the command line

* Empty commit to rerun CI
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
* Use an environment variable for the testing backdoor

* Make the env var a boolean

We'll still have to pass the URL on the command line

* Empty commit to rerun CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants