Template evaluation in action.yml #56

TingluoHuang · 2019-07-23T04:50:33Z

Leverage schema driven yaml parser to read the action.yml file, so we can parse out all the ${{expression}} expressions inside the yaml file and run through template evaluation with them.

ex:

name: 'Hello World'
description: 'Greet the world and record the time'
inputs: 
  greeting: # id of input
    description: 'The greeting we choose - will print ""{greeting}, World!"" on stdout'
    required: true
    default: 'Hello'
  entryPoint: # id of input
    description: 'optional docker entrypoint overwrite.'
    required: false
runs:
  using: 'docker'
  image: 'docker://ubuntu:18.04'
  args:
  - '${{ inputs.greeting }}'
  entrypoint: 'main.sh'
  env:
    Token: foo
    Test: ${{ inputs.entryPoint }}

ericsciple · 2019-07-24T14:04:54Z

src/Runner.Worker/ActionManifestManager.cs

+    [ServiceLocator(Default = typeof(ActionManifestManager))]
+    public interface IActionManifestManager : IRunnerService
+    {
+        ActionDefinitionData LoadManifestFile(IExecutionContext executionContext, string manifestFile);


Shoudl this just be LoadManifest (i.e. is "File" redundant?)

Manifest is also redundant since it's the manifestmanager. Just load?

ericsciple · 2019-07-24T14:06:13Z

src/Runner.Worker/ActionManifestManager.cs

+
+        List<string> EvaluateContainerArguments(IExecutionContext executionContext, SequenceToken token, IDictionary<String, PipelineContextData> contextData);
+
+        Dictionary<String, String> EvaluateContainerEnvironments(IExecutionContext executionContext, MappingToken token, IDictionary<String, PipelineContextData> contextData);


Environment (singular)?

ericsciple · 2019-07-24T14:07:42Z

src/Runner.Worker/ActionManifestManager.cs

+            base.Initialize(hostContext);
+
+            var assembly = Assembly.GetExecutingAssembly();
+            var json = default(String);


ericsciple · 2019-07-24T14:12:04Z

src/Runner.Worker/ActionManifestManager.cs

+            return actionDefinition;
+        }
+
+        public List<string> EvaluateContainerArguments(


ericsciple · 2019-07-24T14:13:29Z

src/Runner.Worker/ActionManifestManager.cs

+                        };
+                    }
+                }
+                else if (string.Equals(usingToken.Value, "node", StringComparison.OrdinalIgnoreCase) ||


can we reduce this to just node12?

All the actions currently use node12 so we should be good.

cool, will remove "node"

ericsciple · 2019-07-24T14:24:57Z

src/Runner.Worker/ActionManifestManager.cs

+    /// <summary>
+    /// Converts a YAML file into a TemplateToken
+    /// </summary>
+    internal sealed class YamlObjectReader : IObjectReader


after the fork, lets move everything into webapi and kill pipelines.yml. This should come from the SDK

ericsciple · 2019-07-24T14:25:29Z

src/Runner.Worker/ActionRunner.cs

@@ -11,6 +11,11 @@
 using Pipelines = GitHub.DistributedTask.Pipelines;
 using GitHub.Runner.Common;
 using GitHub.Runner.Sdk;
+using GitHub.DistributedTask.ObjectTemplating.Schema;


ericsciple · 2019-07-24T14:28:59Z

src/Runner.Worker/Handlers/ContainerActionHandler.cs

@@ -89,6 +113,18 @@ public async Task RunAsync()
                container.ContainerEntryPointArgs = Inputs.GetValueOrDefault("args");
            }

+            if (Data.Environment != null)


will this unintentionally clobber action-author-defined env?

what's the guidance? namespace to avoid collision?

ericsciple · 2019-07-24T14:31:03Z

src/Runner.Worker/action_yaml.json

+            "mapping": {
+                "properties": {
+                    "description": "string",
+                    "required": "boolean",


should we validate required? otherwise should we remove these (should validation fail if we hit keys here we dont understand?)

bryanmacfarlane · 2019-07-24T15:04:36Z

Can you update the description of the PR to give everyone context?

Hooks allowed to work even when context isn't returned

add arm64 support

Creating or uploading artifacts needs a valid accesstoken, downloading without it is still allowed

TingluoHuang force-pushed the users/tihuang/actionschema branch from f425c9c to c2fafc0 Compare July 24, 2019 01:36

add schema file for action.yml, evaluate expression in action.yml

b31f9c8

TingluoHuang force-pushed the users/tihuang/actionschema branch from c2fafc0 to b31f9c8 Compare July 24, 2019 02:03

ericsciple reviewed Jul 24, 2019

View reviewed changes

src/Runner.Worker/ActionManifestManager.cs

return actionDefinition;

}

public List<string> EvaluateContainerArguments(

Copy link

Collaborator

ericsciple Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

ericsciple reviewed Jul 24, 2019

View reviewed changes

ericsciple approved these changes Jul 24, 2019

View reviewed changes

PR feedback.

c05d7d2

fix l0 test

d042edd

TingluoHuang merged commit 9d09123 into master Jul 24, 2019

TingluoHuang deleted the users/tihuang/actionschema branch July 24, 2019 17:12

fhammerl added a commit that referenced this pull request Jun 16, 2022

Merge pull request #56 from fhammerl/stefan-ruvceski/issue-51

45ab8f6

Hooks allowed to work even when context isn't returned

volker-raschek pushed a commit to dedalus-cis4u/github-runner-role that referenced this pull request Jul 25, 2022

Merge pull request actions#56 from lanefu/develop

cafa47b

add arm64 support

jsoref pushed a commit to jsoref/actions-runner that referenced this pull request Oct 7, 2022

feature/block-unknown-artifact-upload (actions#56)

4ba9aba

Creating or uploading artifacts needs a valid accesstoken, downloading without it is still allowed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Template evaluation in action.yml #56

Template evaluation in action.yml #56

TingluoHuang commented Jul 23, 2019 •

edited

ericsciple Jul 24, 2019

bryanmacfarlane Jul 24, 2019

TingluoHuang Jul 24, 2019

ericsciple Jul 24, 2019

TingluoHuang Jul 24, 2019

ericsciple Jul 24, 2019

TingluoHuang Jul 24, 2019

ericsciple Jul 24, 2019

ericsciple Jul 24, 2019

ericsciple Jul 24, 2019

damccorm Jul 24, 2019

TingluoHuang Jul 24, 2019

ericsciple Jul 24, 2019

ericsciple Jul 24, 2019

TingluoHuang Jul 24, 2019

ericsciple Jul 24, 2019

ericsciple Jul 24, 2019

ericsciple Jul 24, 2019

bryanmacfarlane commented Jul 24, 2019


		List<string> EvaluateContainerArguments(IExecutionContext executionContext, SequenceToken token, IDictionary<String, PipelineContextData> contextData);

		Dictionary<String, String> EvaluateContainerEnvironments(IExecutionContext executionContext, MappingToken token, IDictionary<String, PipelineContextData> contextData);

Template evaluation in action.yml #56

Template evaluation in action.yml #56

Conversation

TingluoHuang commented Jul 23, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bryanmacfarlane commented Jul 24, 2019

TingluoHuang commented Jul 23, 2019 •

edited