container action inputs, cleanup, L0 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
force-pushed
the
users/tihuang/inputs
branch
from
f019630
to
1f82a93
Compare
TingluoHuang
commented
Jul 25, 2019
| ContainerName = ExecutionContext.Id.ToString("N"), | ||
| ContainerDisplayName = $"{Pipelines.Validation.NameValidation.Sanitize(Data.ContainerImage)}_{Guid.NewGuid().ToString("N").Substring(0, 6)}", | ||
| ContainerDisplayName = $"{Pipelines.Validation.NameValidation.Sanitize(Data.Image)}_{Guid.NewGuid().ToString("N").Substring(0, 6)}", |
There was a problem hiding this comment.
change NameValidation.Sanitize to something else. :)
ericsciple
approved these changes
Jul 25, 2019
ericsciple
reviewed
Jul 25, 2019
| { | ||
| Data.Image = Data.Image.Substring("docker://".Length); | ||
| } | ||
| else if (Data.Image.EndsWith("Dockerfile") || Data.Image.EndsWith("dockerfile")) |
There was a problem hiding this comment.
should we check for a / or \ ? or what if there is not path separator
TingluoHuang
force-pushed
the
users/tihuang/inputs
branch
from
1f82a93
to
bb60e64
Compare
volker-raschek
pushed a commit
to dedalus-cis4u/github-runner-role
that referenced
this pull request
Jul 25, 2022
Add self hosted GitHub Enterprise support
jsoref
pushed a commit
to jsoref/actions-runner
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.