Add Runner File Commands #684
Conversation
| // Setup File Command Manager | ||
| var fileCommandManager = HostContext.CreateService<IFileCommandManager>(); | ||
| // Container Action Handler will handle the conversion for Container Actions | ||
| var container = handlerData.ExecutionType == ActionExecutionType.Container ? null : ExecutionContext.Global.Container; |
There was a problem hiding this comment.
let's be consistent with existing bugs and add this as the host-path always.
| container.MountVolumes.Add(new MountVolume(defaultWorkingDirectory, "/github/workspace")); | ||
|
|
||
| container.AddPathTranslateMapping(tempHomeDirectory, "/github/home"); | ||
| container.AddPathTranslateMapping(tempWorkflowDirectory, "/github/workflow"); | ||
| container.AddPathTranslateMapping(tempFileCommandDirectory, "/github/file_commands"); |
There was a problem hiding this comment.
doesnt matter really, temp file anyway
| @@ -161,16 +161,21 @@ public async Task RunAsync(ActionRunStage stage) | |||
| Directory.CreateDirectory(tempHomeDirectory); | |||
| this.Environment["HOME"] = tempHomeDirectory; | |||
|
|
|||
| var tempFileCommandDirectory = Path.Combine(tempDirectory, "_runner_file_commands"); | |||
There was a problem hiding this comment.
nit: _runner-file-commands?
| @@ -13,11 +13,13 @@ public sealed class GitHubContext : DictionaryContextData, IEnvironmentContextDa | |||
| "actor", | |||
| "api_url", | |||
| "base_ref", | |||
| "env", | |||
There was a problem hiding this comment.
can we change to allow terminology (existing code above)
| public interface IFileCommandExtension : IExtension | ||
| { | ||
| string ContextName { get; } | ||
| string FileName { get; } |
| } | ||
| } | ||
|
|
||
| private bool TryDeleteFile(string path) |
There was a problem hiding this comment.
consider using IOUtil
| @@ -239,6 +245,8 @@ public async Task RunAsync() | |||
|
|
|||
| // Run the task. | |||
| await handler.RunAsync(Stage); | |||
| fileCommandManager.TryProcessFiles(ExecutionContext, ExecutionContext.Global.Container); | |||
There was a problem hiding this comment.
What if the step fail? Do the file-commands still get processed?
For example, esp consider continue-on-error (script exits 1).
There was a problem hiding this comment.
May need try/finally. If we move into finally, need to make sure doesn't clobber original exception
There was a problem hiding this comment.
if it fails, set task result failed
| @@ -145,6 +145,12 @@ public async Task RunAsync() | |||
| stepHost = containerStepHost; | |||
| } | |||
|
|
|||
| // Setup File Command Manager | |||
There was a problem hiding this comment.
check whether job extension step (initailize job) uses action runner
There was a problem hiding this comment.
may not matter if it doesnt set env/path
| File.Create(newPath).Dispose(); | ||
|
|
||
| var pathToSet = container != null ? container.TranslateToContainerPath(newPath) : newPath; | ||
| context.SetGitHubContext(fileCommand.ContextName, pathToSet); |
There was a problem hiding this comment.
nit: would be rad if more explicitly set in ActionRunner. Hard to mentally keep track where the global context is changed. Today it's only StepsRunner/CompositeActionRunner. May be drawback of plugin abstraction.
| } | ||
| } | ||
|
|
||
| public void TryProcessFiles(IExecutionContext context, ContainerInfo container) |
There was a problem hiding this comment.
nit: Do, do not try :)
| @@ -56,6 +56,10 @@ public sealed class ExtensionManager : RunnerService, IExtensionManager | |||
| Add<T>(extensions, "GitHub.Runner.Worker.EndGroupCommandExtension, Runner.Worker"); | |||
| Add<T>(extensions, "GitHub.Runner.Worker.EchoCommandExtension, Runner.Worker"); | |||
| break; | |||
| case "GitHub.Runner.Worker.IFileCommandExtension": | |||
There was a problem hiding this comment.
nit: personally don't like extension :P
nit: technically not "commands". Wonder if different naming would be more intuitive (less overloading). Thinking about .env file as analogy.
* Add File Runner Commands
* Add File Runner Commands
* Add File Runner Commands
This PR cleans up the file command code in the runner.