preserve date strings in github event payload #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericsciple what is using that encryption code? |
|
@TingluoHuang i dont remember the error offhand. i think the listener lost the connection after a while and couldnt reconnect |
ericsciple
commented
Aug 15, 2019
| } | ||
|
|
||
| jobDispatcher.Run(pipelineJobMessage, runOnce); | ||
| var jobMessage = StringUtil.ConvertFromJson<Pipelines.AgentJobRequestMessage>(message.Body); |
There was a problem hiding this comment.
switched to stringutil here
ericsciple
commented
Aug 15, 2019
| @@ -59,7 +59,7 @@ public async Task<int> RunAsync(string pipeIn, string pipeOut) | |||
| Trace.Info("Message received."); | |||
| ArgUtil.Equal(MessageType.NewJobRequest, channelMessage.MessageType, nameof(channelMessage.MessageType)); | |||
| ArgUtil.NotNullOrEmpty(channelMessage.Body, nameof(channelMessage.Body)); | |||
| var jobMessage = JsonUtility.FromString<Pipelines.AgentJobRequestMessage>(channelMessage.Body); | |||
| var jobMessage = StringUtil.ConvertFromJson<Pipelines.AgentJobRequestMessage>(channelMessage.Body); | |||
There was a problem hiding this comment.
and switched to stringutil here
ericsciple
commented
Aug 15, 2019
| private static Lazy<JsonSerializerSettings> s_serializerSettings = new Lazy<JsonSerializerSettings>(() => | ||
| { | ||
| var settings = new VssJsonMediaTypeFormatter().SerializerSettings; | ||
| settings.DateParseHandling = DateParseHandling.None; |
There was a problem hiding this comment.
dateparsehandling none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.