raise error for set-env, block set node_options. #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hross
reviewed
Nov 2, 2020
hross
approved these changes
Nov 2, 2020
TingluoHuang
added a commit
that referenced
this pull request
Nov 2, 2020
* raise error for set-env, block set node_options. * feedback.
juliobbv
reviewed
Nov 2, 2020
| issue.Data[Constants.Runner.InternalTelemetryIssueDataKey] = $"{Constants.Runner.UnsupportedCommand}_{envName}"; | ||
| context.AddIssue(issue); | ||
|
|
||
| return; |
There was a problem hiding this comment.
Minor: this return; statement was surprising to me to read at first.
I'm guessing that if we ever add more items to _setEnvBlockList, we want the runner to report an error on the first offending env var, instead of all of them, @TingluoHuang?
There was a problem hiding this comment.
I was just want to make sure we don't run
context.Global.EnvironmentVariables[envName] = command.Data;
context.SetEnvContext(envName, command.Data);
context.Debug($"{envName}='{command.Data}'");
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* raise error for set-env, block set node_options. * feedback.
ghost
mentioned this pull request
5 tasks
TingluoHuang
added a commit
that referenced
this pull request
Apr 21, 2021
* raise error for set-env, block set node_options. * feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::set-env::