-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable console color output by default #293
Conversation
I ran into issues doing this in node when setting |
Hey @xt0rted, thank you for your help. I've tested the problem matcher which is defined in Also looks like the In this case, I'm afraid the colorful output by default can break a part of customers who use their custom matchers. Probably, we should refuse these changes and close this PR. |
@vsafonkin thanks for the investigation. Just to make sure I understand, is the issue that ANSI color codes are interfering with problem matcher regexes? |
@brcrista, exactly, if someone uses |
Ok. So in the spirit of "yes, and" ... to ship this we would need to
But yes, in the short term I think we'll just close this. |
I agree, I believe the customers can set these env variables from their side if they need it and it will be safer for them. |
Description:
Set environment variables
DOTNET_SYSTEM_CONSOLE_ALLOW_ANSI_COLOR_REDIRECTION
andTERM
to enable color output by default.Build via current
setup-dotnet
: https://github.com/vsafonkin/dotnet-setup-test/actions/runs/2265449492Build via
setup-dotnet
from PR branch: https://github.com/vsafonkin/dotnet-setup-test/runs/6278013678Related issue:
#288
Check list: