Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Install Scripts #48

Merged
merged 4 commits into from Nov 8, 2019
Merged

Updating Install Scripts #48

merged 4 commits into from Nov 8, 2019

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Nov 8, 2019 •
edited

馃憢 I just started looking at this project and I was unable to run the tests.
It seems there are tests which check for the latest versions of some files and they needed to be updated in source.

Also two things came up during development.

  1. The post commit hooks that are included with Husky seem to indicate that there are generated files that need to be updated.
  2. It might make the development experience easier to ignore changes to the node_modules folder by default. The 6000+ changes threw most of my development tools for a loop.

@ZEisinger ZEisinger merged commit 719c622 into actions:master Nov 8, 2019
@StanleyGoldman StanleyGoldman deleted the script-update branch November 8, 2019 16:05
@ZEisinger ZEisinger mentioned this pull request Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StanleyGoldman @ZEisinger