Race detector *.syso files missing for cross-compilation

[tamird]

This is roughly golang/go#42382.

My understanding is that binaries downloaded from https://github.com/actions/go-versions are built from source, rather than being downloaded from https://go.dev/dl/. But apparently not:

tamird@tamird:~/src/goid/go$ curl -sfSL https://github.com/actions/go-versions/releases/download/1.17.5-1559554870/go-1.17.5-linux-x64.tar.gz | tar zx
tamird@tamird:~/src/goid/go$ find src/runtime -name '*.syso'
src/runtime/race/race_linux_amd64.syso

The official Go binaries have long omitted these files for non-host platforms (https://go-review.googlesource.com/c/build/+/144281/) but that shouldn't have affected go-versions if those packages are indeed built from source. But they appear not to be. It would be nice to fix that so that cross-compilation of race binaries works.

[vsafonkin]

Hi @tamird, thank you for your report, we will take a look it.

[vsafonkin]

@tamird, sorry for the delay, is this issue still actual for you?

[tamird]

I included reproduction instructions in the description. Can you try them?

[vsafonkin]

I included reproduction instructions in the description. Can you try them?

Sure, thank you!

[vsafonkin]

@tamird, I'm afraid that building Go from source code will cause a lot of problems and pretty complicated for maintenance. We already have experience with setup-python action where we use Python builds from source code for each OS platform and it cause many issues with self-hosted runners.

[tamird]

That's fine - it should perhaps be documented how these packages are built.

[vsafonkin]

@tamird, I've added a note about it to the readme file, I believe we can close this issue, thank you for your help!