Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please upgrade go-actions to 1.21.8 / 1.22.1 #462

Closed
silverwind opened this issue Mar 6, 2024 · 3 comments
Closed

Please upgrade go-actions to 1.21.8 / 1.22.1 #462

silverwind opened this issue Mar 6, 2024 · 3 comments
Labels
bug Something isn't working needs triage

Comments

@silverwind
Copy link

silverwind commented Mar 6, 2024 •
edited
Loading

Description:
go-versions dependency is out of date, leading to all repos that use setup-go in combination with govulncheck to fail on the newly published vulnerabilities present in go 1.21.7.

Action version: 5
Platform: all
Runner type: all
Tools version: go 1.21 and 1.22

Repro steps:

steps:
  - uses: actions/setup-go@v5
  with:
    go-version-file: "~1.21"
    check-latest: true

Expected behavior:

Setup go version spec 1.21
Attempting to resolve the latest version from the manifest...
matching 1.21...
Resolved as '1.21.8'

Actual behavior:

Setup go version spec 1.21
Attempting to resolve the latest version from the manifest...
matching 1.21...
Resolved as '1.21.7'
@silverwind silverwind added bug Something isn't working needs triage labels Mar 6, 2024
@silverwind silverwind mentioned this issue Mar 6, 2024
Merged
@silverwind silverwind changed the title Please upgrade go-actions to 1.21.8 Please upgrade go-actions to 1.21.8 / 1.22.1 Mar 6, 2024
@silverwind silverwind mentioned this issue Mar 6, 2024
Open
@jonathan-innis
Copy link

+1 we are hitting this issue as well in kubernetes-sigs/karpenter and aws/karpenter-provider-aws

@jonathan-innis
Copy link

Looks like this literally just got merged: actions/go-versions#97

DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 6, 2024
@earl-warren
[CI] pin go v1.21.8 version
ac0f580 
Because setup-go fails to pick it up.

Refs: actions/setup-go#462
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 6, 2024
@earl-warren
[CI] pin go v1.21.8 version
e3698d8 
Because setup-go fails to pick it up.

Refs: actions/setup-go#462
(cherry picked from commit d7aaefcea9d38ca50a96f34ff42efe954bce4acd)

Conflicts:
	.forgejo/workflows/build-release.yml
	.forgejo/workflows/cascade-setup-end-to-end.yml
	.forgejo/workflows/e2e.yml
	.forgejo/workflows/testing.yml
	trivial context conflict
@silverwind
Copy link
Author

Yes, working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @jonathan-innis