Set LF for all files #214
Merged
Set LF for all files #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brcrista @marko-zivic-93 , could you please review this small PR? |
brcrista
reviewed
Apr 4, 2022
.gitattributes
Outdated
| @@ -1 +1,2 @@ | |||
| * text=auto eol=lf | |||
There was a problem hiding this comment.
Suggested change
| * text=auto eol=lf | |
| * text=auto |
Just calling out:
text=autowill already cause all new files to be converted toLF: https://www.git-scm.com/docs/gitattributes#Documentation/gitattributes.txt-Settostringvalueauto- Adding
eol=lfmeans that existing files will also be converted toLFas they are touched.
I don't feel strongly about it, but I usually go with text=auto since it won't change things that are already working. What do you think?
|
@brcrista, could you please review? |
brcrista
approved these changes
Apr 7, 2022
panticmilos
pushed a commit
to panticmilos/setup-go
that referenced
this pull request
Aug 4, 2022
* Set LF for all files * Set gitattr text=auto
n33pm
pushed a commit
to n33pm/setup-go
that referenced
this pull request
Oct 17, 2022
* Set LF for all files * Set gitattr text=auto
adilhusain-s
pushed a commit
to adilhusain-s/setup-go
that referenced
this pull request
Feb 6, 2023
* Set LF for all files * Set gitattr text=auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Set LF for line endings