Normalize extendedJavaHome environment variable #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extendedJavaHome environment variable contains `.` symbols in the version. This causes the environment variable to be ignored by the action runner. It's best to replace those and other non standard symbols with and underscore. For reference: > Environment variable names used by the utilities in the Shell and Utilities volume of IEEE Std 1003.1-2001 consist solely of uppercase letters, digits, and the '_' (underscore) from the characters defined in Portable Character Set .
konradpabjan
approved these changes
Jun 17, 2020
ericsciple
reviewed
Jun 17, 2020
| // uppercase letters, digits, and the underscore. Therefore we convert | ||
| // the extendedJavaHome variable to upper case and replace '.' symbols and | ||
| // any other non-alphanumeric characters with an underscore. | ||
| extendedJavaHome = extendedJavaHome.toUpperCase().replace(/[^0-9A-Z_]/g, '_'); |
There was a problem hiding this comment.
This looks like a breaking change. Should the old variable be set also, so existing customers dont get broken?
There was a problem hiding this comment.
Good point. It could break certain users if they're actually able to use the current variable.
When we eventually release a v2 version of setup-java, then we can remove the old one (we don't promise compat between the new versions).
There was a problem hiding this comment.
Sounds good, I just pushed a new commit that keeps the old variable.
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extendedJavaHome environment variable contains
.symbols in the version.This causes the environment variable to be ignored by the action runner.This makes the variable inaccessible withbash's${VAR}syntax . It's best to replace those and other non standard symbols with and underscore.For reference:
See also: https://unix.stackexchange.com/questions/93532/exporting-a-variable-with-dot-in-it