Skip to content

Commit

Permalink
feat: handling the case where "node" is used for tool-versions file. (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
xytis committed Jul 18, 2023
1 parent c7a93de commit ca2d4e0
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/versions.yml
Expand Up @@ -158,7 +158,8 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version-file: [.nvmrc, .tool-versions, package.json]
node-version-file:
[.nvmrc, .tool-versions, .tool-versions-node, package.json]
steps:
- uses: actions/checkout@v3
- name: Remove volta from package.json
Expand Down
1 change: 1 addition & 0 deletions __tests__/data/.tool-versions-node
@@ -0,0 +1 @@
node 14.0.0
2 changes: 1 addition & 1 deletion dist/cache-save/index.js
Expand Up @@ -60754,7 +60754,7 @@ function parseNodeVersionFile(contents) {
core.info('Node version file is not JSON file');
}
if (!nodeVersion) {
const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m);
const found = contents.match(/^(?:node(js)?\s+)?v?(?<version>[^\s]+)$/m);
nodeVersion = (_c = found === null || found === void 0 ? void 0 : found.groups) === null || _c === void 0 ? void 0 : _c.version;
}
// In the case of an unknown format,
Expand Down
2 changes: 1 addition & 1 deletion dist/setup/index.js
Expand Up @@ -72336,7 +72336,7 @@ function parseNodeVersionFile(contents) {
core.info('Node version file is not JSON file');
}
if (!nodeVersion) {
const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m);
const found = contents.match(/^(?:node(js)?\s+)?v?(?<version>[^\s]+)$/m);
nodeVersion = (_c = found === null || found === void 0 ? void 0 : found.groups) === null || _c === void 0 ? void 0 : _c.version;
}
// In the case of an unknown format,
Expand Down
2 changes: 1 addition & 1 deletion src/util.ts
Expand Up @@ -13,7 +13,7 @@ export function parseNodeVersionFile(contents: string): string {
}

if (!nodeVersion) {
const found = contents.match(/^(?:nodejs\s+)?v?(?<version>[^\s]+)$/m);
const found = contents.match(/^(?:node(js)?\s+)?v?(?<version>[^\s]+)$/m);
nodeVersion = found?.groups?.version;
}

Expand Down

0 comments on commit ca2d4e0

Please sign in to comment.