delete master branch, potentially turn into a tag?

[karlbrown-va]

Description:
At this point #171 the master branch was changed to main. However, we still had actions pointing to master, which one would normally assume would link to the latest tip. Since master is now moribund this branch should be deleted, which will likely cause existing actions to break. Or, the branch can be deleted and a new tag can be maintained of 'master' until such time as people have migrated over to using main or v2 etc.

Action version:
v2.5

Platform:

• Ubuntu
• [x ] macOS
• Windows

Runner type:

• [x ] Hosted
• Self-hosted

Tools version:
n/a

Repro steps:
create an action linking to setup-node/master. Notice how it pulls in an older version.

Expected behavior:
Master should link to the tip.

Actual behavior:
Master is now a stale branch. So the branch should be deleted or replaced with a continuously updating tag.

[dmitry-shibanov]

Hello @karlbrown-va. Thank you for your report. The master branch links to v1 tag. The latest major tag points to the main branch. We recommend to use tags, because the latest code of the branches can be carrying breaking changes.

[karlbrown-va]

Hi, understood. However you might consider deleting the master branch. It’s a bit confusing to have both master and main as branches. One would assume master would point to the tip. We’ve changed our code to use tags, but the behavior of master being v1 is unexpected and at the very least maybe consider documenting this if it’s not already and if you want to keep the master branch as a branch. On Dec 23, 2021, at 09:24, Dmitry Shibanov ***@***.***> wrote:  Hello @karlbrown-va <https://github.com/karlbrown-va>. Thank you for your report. The master branch links to v1 tag. The latest major tag points to the main branch. We recommend to use tags, because the latest code of the branches can be carrying breaking changes. — Reply to this email directly, view it on GitHub <#386 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANONOZITBYT6JLLBK2WGQ6TUSMWLBANCNFSM5KSZKCGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>