Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js RC version #454

Closed
yisibl opened this issue Mar 31, 2022 · 5 comments
Closed

Support Node.js RC version #454

yisibl opened this issue Mar 31, 2022 · 5 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@yisibl
Copy link

yisibl commented Mar 31, 2022

I need to verify that an RC version of Node.js resolves a bug, is there a way to specify this version?

For example, I need to test v12.22.12-rc.0 and other LTS version. https://nodejs.org/download/rc/

My CI config:

    strategy:
      fail-fast: false
      matrix:
        os: [ubuntu-latest, windows-latest]
        node: [12, 14, 16]

      - name: Set up Node.js
        uses: actions/setup-node@v3
        with:
          node-version: ${{ matrix.node }}
          cache: npm

See also: #360

@yisibl yisibl added feature request New feature or request to improve the current logic needs triage labels Mar 31, 2022
@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Mar 31, 2022

Hello @yisibl. Thank you for your report. The setup-node action does not install release candidates.

@dominykas
Copy link

There is a PR open that would enable support for the nightlies: #360

@yisibl
Copy link
Author

yisibl commented Apr 1, 2022

I've changed to setup-node-nvm to install the RC version, but I still want setup-node to support this.

yisibl/svg-sprite@48a402f

@dmitry-shibanov
Copy link
Contributor

Hello everyone. We released and updated the major tag with changes to install rc versions. Could you please confirm that everything works as expected?

jobs:
  build:
    runs-on: ubuntu-latest
    name: Node sample
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: '16.0.0-rc.1’
      - run: npm ci
      - run: npm test

@dmitry-shibanov
Copy link
Contributor

Hello everyone. For now I'm going to close the issue.

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
* Fix a few typos in `README.md`

* docs(README): fix typos

Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants