Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for NODE_AUTH_TOKEN overwritten #205

Merged
merged 10 commits into from Dec 16, 2020
Merged

Check for NODE_AUTH_TOKEN overwritten #205

merged 10 commits into from Dec 16, 2020

Conversation

@zodman
Copy link
Contributor

@zodman zodman commented Oct 21, 2020

the updated version of #83

If i set the NODE_AUTH_TOKEN and then execute the àctions/setup-node the NODE_AUTH_TOKEN was overwriten with XXXXX and lost my variable value.

What actually fix this:

      - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV
      - name: Use Node.js 12.x
        uses: actions/setup-node@v2.1.2
        with:
          node-version: 12.x
          registry-url: https://npm.pkg.github.com/
          scope: '@foo'
      - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV

With the patch

      - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV
      - name: Use Node.js 12.x
        uses: actions/setup-node@v2.1.2
        with:
          node-version: 12.x
          registry-url: https://npm.pkg.github.com/
          scope: '@foo'
@zodman zodman changed the title adding test for NODE_AUTH_TOKEN overwritten Check for NODE_AUTH_TOKEN overwritten Oct 22, 2020
@nikita-bykov
Copy link

@nikita-bykov nikita-bykov commented Dec 14, 2020

Hello @zodman! Thank you for your contribution! We apologize that the review takes too long.
Your changes generally look good for us. Please pull the latest changes from the main branch, rebuild dist file and after that we can merge the PR.

@zodman
Copy link
Contributor Author

@zodman zodman commented Dec 15, 2020

@maxim-lobanov pulled last changes ..

@maxim-lobanov maxim-lobanov merged commit d06286d into actions:main Dec 16, 2020
46 checks passed
46 checks passed
@github-actions
Check licenses
Details
@github-actions
build (ubuntu-latest)
Details
@github-actions
test-proxy
Details
@github-actions
local-cache (ubuntu-latest, 10)
Details
@github-actions
build (windows-latest)
Details
@github-actions
local-cache (ubuntu-latest, 12)
Details
@github-actions
build (macos-latest)
Details
@github-actions
local-cache (ubuntu-latest, 14)
Details
@github-actions
local-cache (windows-latest, 10)
Details
@github-actions
local-cache (windows-latest, 12)
Details
@github-actions
local-cache (windows-latest, 14)
Details
@github-actions
local-cache (macos-latest, 10)
Details
@github-actions
local-cache (macos-latest, 12)
Details
@github-actions
local-cache (macos-latest, 14)
Details
@github-actions
test-bypass-proxy
Details
@github-actions
manifest (ubuntu-latest, 10.15)
Details
@github-actions
manifest (ubuntu-latest, 12.16.0)
Details
@github-actions
manifest (ubuntu-latest, 14.2.0)
Details
@github-actions
manifest (windows-latest, 10.15)
Details
@github-actions
manifest (windows-latest, 12.16.0)
Details
@github-actions
manifest (windows-latest, 14.2.0)
Details
@github-actions
manifest (macos-latest, 10.15)
Details
@github-actions
manifest (macos-latest, 12.16.0)
Details
@github-actions
manifest (macos-latest, 14.2.0)
Details
@github-actions
check-latest (ubuntu-latest, 10)
Details
@github-actions
check-latest (ubuntu-latest, 11)
Details
@github-actions
check-latest (ubuntu-latest, 12)
Details
@github-actions
check-latest (ubuntu-latest, 14)
Details
@github-actions
check-latest (windows-latest, 10)
Details
@github-actions
check-latest (windows-latest, 11)
Details
@github-actions
check-latest (windows-latest, 12)
Details
@github-actions
check-latest (windows-latest, 14)
Details
@github-actions
check-latest (macos-latest, 10)
Details
@github-actions
check-latest (macos-latest, 11)
Details
@github-actions
check-latest (macos-latest, 12)
Details
@github-actions
check-latest (macos-latest, 14)
Details
@github-actions
node-dist (ubuntu-latest, 11)
Details
@github-actions
node-dist (ubuntu-latest, 13)
Details
@github-actions
node-dist (windows-latest, 11)
Details
@github-actions
node-dist (windows-latest, 13)
Details
@github-actions
node-dist (macos-latest, 11)
Details
@github-actions
node-dist (macos-latest, 13)
Details
@github-actions
old-versions (ubuntu-latest)
Details
@github-actions
old-versions (windows-latest)
Details
@github-actions
old-versions (macos-latest)
Details
@github-actions
arch
Details
@maxim-lobanov
Copy link
Contributor

@maxim-lobanov maxim-lobanov commented Dec 16, 2020

@zodman thank you for contribution!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants