Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #475

Merged
merged 2 commits into from Apr 26, 2022
Merged

Update README.md #475

merged 2 commits into from Apr 26, 2022

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Apr 26, 2022

Description:
Fix MarkdownLint and simplify version usage

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Saibamen Saibamen marked this pull request as ready for review Apr 26, 2022
@Saibamen Saibamen requested a review from as a code owner Apr 26, 2022
@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 26, 2022

Hello @Saibamen. Thank you for your pull request. Could you please revert header level changes ? I think it's better to keep them as Heading level 1. Besides, it will be consistent with other actions/setup- repositories.

@brcrista
Copy link
Contributor

@brcrista brcrista commented Apr 26, 2022

@dmitry-shibanov I actually thought the heading level was appropriate here. Usually H1 is used for the document title and then H2 for section headings

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 26, 2022

If it's so, I think it should be good. We can merge it. Thank you.

@brcrista brcrista merged commit 25184c4 into actions:main Apr 26, 2022
1 check passed
@Saibamen Saibamen deleted the patch-1 branch Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants