Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Include warning when configuring token to install private packages #528

Merged
merged 2 commits into from Jul 4, 2022

Conversation

jamesottaway
Copy link
Contributor

@jamesottaway jamesottaway commented Jun 26, 2022

The distinction between secrets.GITHUB_TOKEN and secrets.NPM_TOKEN cost myself and a colleague numerous hours when we were trying to fix a GitHub Actions workflow which needed to install a private package from a different repository from our GitHub organisation.

Given the issue dedicated to this point is closed, we should include a warning here to make it more clear why secrets.GITHUB_TOKEN will not work when passed to npm ci, in the presence of private packages from other GitHub Package repositories.

Description:
Describe your changes.

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

The distinction between `secrets.GITHUB_TOKEN` and `secrets.NPM_TOKEN` cost myself and a colleague numerous hours when we were trying to fix a GitHub Actions workflow which needed to install a private package from a different repository from our GitHub organisation.

Given the issue dedicated to this point is closed, we should include a warning here to make it more clear why `secrets.GITHUB_TOKEN` will not work when passed to `npm ci`, in the presence of private packages from other GitHub Package repositories.
@jamesottaway jamesottaway requested a review from a team as a code owner Jun 26, 2022
@marko-zivic-93 marko-zivic-93 merged commit 0f15a51 into actions:main Jul 4, 2022
1 check passed
@jamesottaway jamesottaway deleted the patch-1 branch Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants