Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPy3.8 #261

Closed
henryiii opened this issue Oct 21, 2021 · 5 comments
Closed

Add PyPy3.8 #261

henryiii opened this issue Oct 21, 2021 · 5 comments
Labels
feature request New feature or request to improve the current logic

Comments

@henryiii
Copy link

Description:
Add support for PyPy3.8.

Justification:
PyPy used to support pypy3.6 and pypy3.7, then they just supposed pypy3.7, and now they support pypy3.7 and pypy3.8 (most recent release, 7.3.6). It would be nice to have pypy3.8, and I don't see that listed anywhere in this repo.

Are you willing to submit a PR?
Possibly, it it helps.

@henryiii henryiii added feature request New feature or request to improve the current logic needs triage labels Oct 21, 2021
@henryiii henryiii changed the title Add PyPy 3.8 Add PyPy3.8 Oct 21, 2021
@mattip
Copy link

mattip commented Oct 24, 2021

I think this is a documentation issue. The identifier pypy-3.8-v7.3.6 or pypy-3.8 should JustWork as long as it appears in the versions.json file. With that, maybe work is needed to cache it?

@nikita-bykov
Copy link
Contributor

Hello @henryiii!
pypy-3.8 is already available via the setup-python action and as @mattip mentioned before you should use identifier like pypy-3.8 (Specifying a PyPy version).
Sample code:

- uses: actions/setup-python@v2
  with:
    python-version: 'pypy-3.8'
    architecture: 'x64'

This version is not preinstalled on our images, but if you'd like to suggest adding it, please create an issue in virtual-environments repository.
I'll close this issue, but if you have any questions feel free to ask.

@mattip
Copy link

mattip commented Oct 26, 2021

See actions/runner-images#4345

@mattip
Copy link

mattip commented Oct 26, 2021

Hmm, that was wrong. See actions/runner-images#4347

@henryiii
Copy link
Author

I think you can get 7.3.7 with setup-python@v2, but you have to request it explicitly in the case of 3.7, since that's cached. I haven't tried yet, though I have started using pypy-3.8. Having it cached (and 3.7's cache bumped to 7.3.7) would be nice.

niccokunzmann added a commit to niccokunzmann/icalendar that referenced this issue Aug 14, 2022
niccokunzmann added a commit to niccokunzmann/icalendar that referenced this issue Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants