Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip on macos-12 does not support wheels built on the same platform (problem appeared on Jul 21) #469

Closed
2 of 5 tasks
slayoo opened this issue Jul 21, 2022 · 5 comments
Closed
2 of 5 tasks
Labels
bug Something isn't working

Comments

@slayoo
Copy link

slayoo commented Jul 21, 2022

Description:
(seems similar to #279)
wheels built locally are not installable, pip debug does not list host platform as one of compatible tags

Action version:
worked OK up till today with sys.version: 3.10.5 (main, Jun 7 2022, 06:48:49) [Clang 12.0.0 (clang-1200.0.32.29)]
fails since today with: sys.version: 3.10.5 (main, Jul 11 2022, 14:33:08) [Clang 12.0.0 (clang-1200.0.32.29)]

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Run actions/setup-python@v1
  with:
    python-version: 3.10
    architecture: x64
  macOS
  12.4

Repro steps:
pip debug --verbose

this morning (when it worked OK, https://github.com/open-atmos/PyPartMC/runs/7449996034?check_suite_focus=true):

...
Compatible tags: 2083
  cp310-cp310-macosx_12_0_x86_64
  cp310-cp310-macosx_12_0_intel
  cp310-cp310-macosx_12_0_fat64
  cp310-cp310-macosx_12_0_fat32
...

a few hours later (https://github.com/open-atmos/PyPartMC/runs/7454643791?check_suite_focus=true):

...
Compatible tags: 1807
  cp310-cp310-macosx_10_16_x86_64
  cp310-cp310-macosx_10_16_intel
  cp310-cp310-macosx_10_16_fat64
  cp310-cp310-macosx_10_16_fat32
  cp310-cp310-macosx_10_16_universal2
...

Expected behavior:
A python package wheel built on a local machine should be installable on a local machine.

Actual behavior:
It is not, pip claims that ...macosx_12_0_x86_64.whl is not a supported wheel on this platform.

@slayoo slayoo added bug Something isn't working needs triage labels Jul 21, 2022
slayoo added a commit to open-atmos/PyPartMC that referenced this issue Jul 21, 2022
@IvanZosimov
Copy link
Contributor

Hi, @slayoo 👋 Thank you for the issue, as a workaround you can try to specify the env.variable SYSTEM_VERSION_COMPAT: 0 on the job's level, as it was suggested here:

build:
    needs: [todos_annotated]
    strategy:
      matrix:
        platform: [ubuntu-latest, macos-12, windows-latest]
        python-version: ["3.7", "3.8", "3.9", "3.10"]
        exclude:
          - platform: macos-12
            python-version: "3.7"
          - platform: macos-12
            python-version: "3.8"
          - platform: macos-12
            python-version: "3.9"
    runs-on: ${{ matrix.platform }}
    env:
      SYSTEM_VERSION_COMPAT: 0
    steps:
      - if: startsWith(matrix.platform, 'macos-')

Please, let us know if this workaround is working for you 💌

@slayoo
Copy link
Author

slayoo commented Jul 25, 2022

Thank you, I will try it as a workaround and report back.
Still, it would be great to be able to:

  • not need to communicate such workarounds to everyone downstream who wants to use the package on Github Actions
  • test if package installation works on a given macOS release (which is the very reason why we are calling pip install before uploading to PyPI.org in these workflows)
  • avoid such surprising random-looking regressions as the one that happened with the Jul 11 builds

Thanks for your help

slayoo added a commit to open-atmos/PyPartMC that referenced this issue Jul 25, 2022
workaround macOS install issue with SYSTEM_VERSION_COMPAT=0 (actions/setup-python#469)
@slayoo
Copy link
Author

slayoo commented Jul 25, 2022

(just confirming, the env-var workaround seems to work with 3.10.5 (main, Jul 11 2022, 14:33:08))

@IvanZosimov
Copy link
Contributor

Thank you for your feedback, @slayoo 💌

By now I'm going to close this issue, If you have any questions feel free to ping us.

drbenmorgan added a commit to drbenmorgan/LegendGeom that referenced this issue Nov 21, 2022
As reported on the issue tracker for the actions/setup-python action:

actions/setup-python#469

A workaround is needed to get pip installs to recognize macOS>=11
as a compatible platform.
drbenmorgan added a commit to drbenmorgan/LegendGeom that referenced this issue Nov 21, 2022
Address build/test failures on CI:

- Reduce build matrix to platforms/python versions that pyg4ometry dependency
  provides wheels for.
- As reported on the issue tracker for the actions/setup-python action:

  - actions/setup-python#469

  The SYSTEM_VERSION_COMPAT wnv var needed to get pip installs to recognize
  macOS>=11 as a compatible platform when using that action.
- Add a minimal test case to check import/package version.
- Fix issues in documentation build caused by package structure:
  - Migrate developer scripts out of package, to be determined if
    they can be used in testing.
  - Update import statements to reflect new package layout.
@altendky
Copy link

I don't really get why this is considered resolved. Only a workaround was provided, not a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants