Only add ruby in $PATH, do not overwrite /usr/bin/ruby #29
Conversation
* Fixes actions#18 * The symlink never worked on macOS, and there was a missing `await`. * No tool should hardcode `/usr/bin/ruby`, but instead executables should use `#!/usr/bin/env ruby`. * If a specific tool needs the symlink, then it can of course be added as part of the steps of that CI.
|
Hi @eregon, any chance to get this merged soon ? Thanks in advance ! |
|
@damccorm Could you review this? |
|
@bryanmacfarlane may we kindly ask you to have a look at this in near time 🙏 |
|
👀 |
|
We have eventually ended up forking |
|
Nice! |
|
@eileencodes sorry for a direct ping, but is it possible to have this tagged through git, so we don't have to reference unstable master? It has been a week since this PR got merged, and we would really like to drop our fork. Or do you plan to bundle more changes into the next version, whatever that would be? |
|
I can handle that hopefully today. |
|
Much appreciated 🙇 |
|
@dentuzhik , I created a v1.1.1 release and tag. Can you validate it using @v1.1.1 and if you give the green light, I'll push v1 tag |
|
👍 we will let you know asap, thanks a lot! |
|
Everything seems working fine for us, though we are wondering why do you want to override existing v1 tag, rather than create a new one ( There have been quite a few things merged lately, and I have no context whether it's ok for everyone else using v1 atm |
|
Because folks that bind to https://github.com/actions/toolkit/blob/master/docs/action-versioning.md Actions are major versioned when there are compat or behavior breaks. Note there are no minor tags published. Just exact versions and major tag. |
|
Note that for the record, it seems the previous logic comes from https://github.com/microsoft/azure-pipelines-tasks/blob/136fb486417bf4d21d63bf8854eb944d333a292d/Tasks/UseRubyVersionV0/userubyversion.ts#L43-L49 |
await./usr/bin/ruby, but instead executablesshould use
#!/usr/bin/env ruby.added as part of the steps of that CI.