Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid stale for specific milestone(s) - Like label does #270

Closed
C0ZEN opened this issue Jan 16, 2021 · 5 comments · Fixed by #279 or C0ZEN/stale#7
Closed

Avoid stale for specific milestone(s) - Like label does #270

C0ZEN opened this issue Jan 16, 2021 · 5 comments · Fixed by #279 or C0ZEN/stale#7
Labels
enhancement New feature or request

Comments

@C0ZEN
Copy link
Contributor

C0ZEN commented Jan 16, 2021

See #236
@hross hross added the enhancement New feature or request label Jan 17, 2021
@C0ZEN C0ZEN changed the title Avoid stale for specific milestone(s) - Like label does Avoid stale for specific milestone - Like label does Jan 17, 2021
@C0ZEN C0ZEN changed the title Avoid stale for specific milestone - Like label does Avoid stale for specific milestone(s) - Like label does Jan 17, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jan 17, 2021
@C0ZEN
feat(exempt): add new options to exempt the milestones
d8a3b69 
closes actions#270
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jan 18, 2021
@C0ZEN
feat(exempt): add new options to exempt the milestones
96cebd2 
closes actions#270
@C0ZEN C0ZEN mentioned this issue Jan 18, 2021
Merged
6 tasks
hross pushed a commit that referenced this issue Jan 19, 2021
@C0ZEN
feat(exempt): add new options to exempt the milestones (#279)
f71123a 
* feat(exempt): add new options to exempt the milestones

closes #270

* test(milestones): add coverage

* test(issue): add coverage

* chore(rebase): fix all errors due to the rebase

also made some changes regarding the change I made with the lint scripts and prettier. I did not saw that some scripts were already here and I created to more to keep the old ones as well

* test(milestone): add coverage

* chore(index): update index

* fix(checks): remove checks over optional number options

the code was actually handling the case where the values are NaN so it's fine
@FabianKoestring
Copy link

Thank you very much! Maybe add a option to ignore every issue/pr with any milestone. We use calendar weeks as milestones and have to add a long list of names to exempt-milestones. Just an idea. 😉

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jan 19, 2021

@FabianKoestring haha that's nice that you ask for this feature to be honest because I was planning to do so at first and then I told myself: KISS.
I dunno though if it's better to have a special milestone name or a new option but I hardly see what it can be anyway since the milestone option accept a string, any kind of value could be considered as a milestone as well as an exception.
So going for something like 'exempt-all-milestones' as boolean would be nice.
What do you think?

@FabianKoestring
Copy link

@FabianKoestring haha that's nice that you ask for this feature to be honest because I was planning to do so at first and then I told myself: KISS.
I dunno though if it's better to have a special milestone name or a new option but I hardly see what it can be anyway since the milestone option accept a string, any kind of value could be considered as a milestone as well as an exception.
So going for something like 'exempt-all-milestones' as boolean would be nice.
What do you think?

exempt-all-milestones - this is genius!

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jan 19, 2021

@FabianKoestring haha not so much sadly.
Do you think that we should also create the exempt-all-pr-milestones and exempt-all-issue-milestones?
It seems to me that the need to split the config in half regarding either it's an issue or a pr is somehow a must have these days.

@FabianKoestring
Copy link

It may be usefull. For our usecase it would be enough to just ignore every pr/issue with a milestone. As soon as somebody handle prs and issues differently it would be nice to have the ability to configure it. 👌

This was referenced Jan 19, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@hross @FabianKoestring @C0ZEN