Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the IssueProcessor #272

Closed
C0ZEN opened this issue Jan 17, 2021 · 0 comments · Fixed by #290, C0ZEN/stale#9 or C0ZEN/stale#10
Closed

Refactor the IssueProcessor #272

C0ZEN opened this issue Jan 17, 2021 · 0 comments · Fixed by #290, C0ZEN/stale#9 or C0ZEN/stale#10
Labels
enhancement New feature or request

Comments

@C0ZEN
Copy link
Contributor

C0ZEN commented Jan 17, 2021

I would like to:

  • Move the interfaces inside src/interfaces with one file per interface
  • Create a new class to handle a single issue (seems rather hard and basically means rewrote a lot of stuff so I will skip this one)
  • Rename IssueProcessor to IssuesProcessor

It will reduce the complexity of the IssueProcessor class.
It will help to avoid creating a bunch of time the same class for the Logger.

@hross hross added the enhancement New feature or request label Jan 18, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jan 23, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Feb 13, 2021
hross pushed a commit that referenced this issue Feb 16, 2021
* refactor: move and rename the interfaces/classes

closes #272

* docs: update the readme and action to describe the new options for milestones

* refactor: split the tests into multiple files

* feat(milestones): add new options to exempt all milestones

* test: add coverage for the default values

* test(milestones): add more coverage (wip)

* test(milestones): add more coverage for the multiple exempt milestones

* test: reduce duplicated code

* test: change some describes

* test: add more coverage

* test: add more coverage

* test: add final coverage

* build(tsc): add missing project flag to build with the right tsconfig

* test(milestones): use each to reduce the complexity of the tests

* chore: fix an eslint issue with prettier on windows

the end of line was wrong each time the os process the files

* docs: move the contribution section to a dedicated file

add more content to help the debug

* chore: make sure the rebase is ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants