Stale label not being added

[nijel]

Stale label not being added at all in our repo. To give a specific example, let's take WeblateOrg/weblate#4746

On the last nightly run, the log contains the following entries:

[#4746] Found issue: issue #4746 last updated 2021-01-06T08:51:34Z (is pr? false)
[#4746] Days before issue stale: 10
[#4746] This issue hasn't a stale label

So, the action sees the issue is old, gets correct stale days and sees that the label is not there. It just doesn't label it as stale.

Things most likely go wrong here:

stale/src/IssueProcessor.ts

Line 280 in f71123a

if (!issue.isStale && shouldBeStale && shouldMarkAsStale) {

The question is how to figure out whether there is a bug in the action or there is something misconfigured on our side.

[nijel]

It turns out to be caused by not properly working issue/pr delays.

• The log shows days-before-issue-stale
• The code actually uses days-before-stale to check the staleness

I've changed the perameters in WeblateOrg/meta@761741d to use the shorter period in days-before-stale and extend it in days-before-pr-stale and now the issue is correctly marked as stale (it would also mark as stale PRs which we don't want to get marked as stale, but luckily we don't have any right now):

[#4746] Found issue: issue #4746 last updated 2021-01-06T08:51:34Z (is pr? false)
[#4746] Days before issue stale: 10
[#4746] This issue hasn't a stale label
[#4746] Marking issue stale because it was last updated on 2021-01-06T08:51:34Z and it does not have a stale label
[#4746] Marking issue #4746 as stale
[#4746] Found a stale issue
[#4746] Checking for label on issue #4746
[#4746] Issue #4746 marked stale on: 2021-02-04T09:36:26Z
[#4746] Checking for comments on issue #4746 since 2021-02-04T09:36:26Z
[#4746] Comments not made by actor or another bot: 0
[#4746] Issue #4746 has been commented on: false
[#4746] Days before issue close: 4
[#4746] Issue #4746 has been updated: true
[#4746] Stale issue is not old enough to close yet (hasComments? false, hasUpdate? true)

Should be fixed by #304