Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-issue operation count can be inaccurate #661

Closed
Mike-Bell opened this issue Jan 27, 2022 · 0 comments · Fixed by #662
Closed

per-issue operation count can be inaccurate #661

Mike-Bell opened this issue Jan 27, 2022 · 0 comments · Fixed by #662
Labels
bug Something isn't working

Comments

@Mike-Bell
Copy link
Contributor

Mike-Bell commented Jan 27, 2022

Describe your issue

There are several operations that correctly count against the operations-per-run limit but do not get added to the per-issue tally as represented in the logging for each issue, e.g. 1 operation consumed for this pull request. This can be mildly confusing if you're paying close attention to your logs and trying to understand what's happening in detail (especially when you're running into the operation limit)

Further context

I noticed this because I have a repo where I'm running into the operation limit but if I manually tally up the operations listed in the issues in the logs, the numbers don't add up. Digging through the code a little, I think the problem is that there are a couple places calling this.operations.consumeOperation(); where they should be calling this._consumeIssueOperation(), e.g.

this.operations.consumeOperation();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant