Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix per issue operation count #662

Merged
merged 2 commits into from Feb 4, 2022

Conversation

Mike-Bell
Copy link
Contributor

Changes

  • Fixes an issue where per-issue operation count could be inaccurate in some cases

Context

fixes #661

I wanted to add some unit tests and fix the problem TDD-style, but this proved to be tough given the way that issues-processor is currently mocked out, so I gave up. Related, I also think that some of the tests in https://github.com/actions/stale/blob/main/__tests__/operations-per-run.spec.ts are making incorrect assertions because some of the methods that increment operation count get mocked. This all seems pretty fixable, but I think that would require more churn than I'm comfortable introducing right now, so if tests are required for this PR I think I'll leave it to someone else.

@Mike-Bell Mike-Bell requested a review from a team as a code owner Jan 27, 2022
@luketomlinson luketomlinson merged commit 7a7efca into actions:main Feb 4, 2022
5 checks passed
@Mike-Bell Mike-Bell deleted the FixIssueOperationCount branch Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

per-issue operation count can be inaccurate
2 participants