Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stale-issue-comment): update the docs to remove that omitting the option will not send a message #522

Merged
merged 7 commits into from
Sep 22, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jul 7, 2021

Changes

  • Update the doc to mention that a message will be sent with the default workflow
  • Update the doc to remove the part that say that the stale issue message will not be sent when omitted (since the code is checking for empty string and there is a default value, a comment should be added for issue and PRs due to this default value)
  • Add a test to confirm this

Closes #521

@C0ZEN C0ZEN marked this pull request as ready for review July 9, 2021 21:27
@C0ZEN C0ZEN requested a review from a team as a code owner July 9, 2021 21:27
@C0ZEN C0ZEN changed the title docs(stale-issue-comment): update the docs to remove that omitting wi… docs(stale-issue-comment): update the docs to remove that omitting will not send a message Jul 9, 2021
@C0ZEN C0ZEN changed the title docs(stale-issue-comment): update the docs to remove that omitting will not send a message docs(stale-issue-comment): update the docs to remove that omitting the option will not send a message Jul 9, 2021
@actions actions deleted a comment Jul 12, 2021
@actions actions deleted a comment Jul 14, 2021
@actions actions deleted a comment Jul 14, 2021
@actions actions deleted a comment Jul 14, 2021
README.md Outdated Show resolved Hide resolved
src/classes/issues-processor.ts Outdated Show resolved Hide resolved
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Aug 19, 2021

up

@github-actions github-actions bot removed the Stale label Aug 20, 2021
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Sep 19, 2021

ready

C0ZEN and others added 7 commits September 21, 2021 13:21
…ll not send a message

To be sure, what would be even better is to add a test using the default config (because the main issue is that the default options of the specs are not matching the ones from the action).

Closes actions#521
Co-authored-by: Luke Tomlinson <luketomlinson@github.com>
@@ -872,7 +872,11 @@ export class IssuesProcessor {
private async _deleteBranch(issue: Issue): Promise<void> {
const issueLogger: IssueLogger = new IssueLogger(issue);

issueLogger.info(`Delete branch from closed $$type - ${issue.title}`);
issueLogger.info(`Delete
branch from closed $
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option stale-issue-message required?
3 participants