Fix an issue where the bot doesn't ignore its own comments #73
Conversation
| comments.filter( | ||
| comment => | ||
| comment.user.type === 'User' && | ||
| comment.user.login !== github.context.actor |
There was a problem hiding this comment.
@hross I added a scheduled workflow with the stale action and it seems that github.context.actor is myself, not the github actions bot. As a result, an issue that I had commented on after it was labeled stale ended up getting closed anyway. Here's what's in the logs for the action (incorrectly claiming that I am a bot):
Checking for comments on issue #15419 since 2020-09-22T00:06:03Z
Comments not made by rmacklin or another bot: 0
According to this post in the GitHub support community, it's expected behavior that the actor will be the user who set up the schedule:
https://github.community/t/who-will-be-the-github-actor-when-a-workflow-runs-on-a-schedule/17369
So if the intention of this check was to ignore bot comments, it seems like it's not working as intended.
There was a problem hiding this comment.
Seems like others have run into the same issue: #21 (comment)
There was a problem hiding this comment.
I've opened #192 where I propose we stop filtering out comments by github.context.actor when determining if there has been activity on the PR since it was marked as stale.
No description provided.