Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ada starter workflow, icon and properties #493

Merged
merged 13 commits into from Aug 25, 2020
Merged

Conversation

mosteo
Copy link
Contributor

@mosteo mosteo commented May 3, 2020

This is a basic workflow to compile Ada projects with the GCC compiler, GNAT, through its project compilation tool, GPRbuild.

Some resources about Ada and GNAT:

  • https://github.com/ohenley/awesome-ada

  • http://www.getadanow.com/

  • Include a good description of the workflow.

  • Links to the language or tool will be nice (unless its really obvious)

  • The workflow filename of CI workflows should be the name of the language or platform, in lower case. Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").

  • Includes a matching ci/properties/*.properties.json file.

  • Use sentence case for the names of workflows and steps, for example "Run tests".

  • The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")

  • Include comments in the workflow for any parts that are not obvious or could use clarification.

  • CI workflows should run on push to branches: [ master ] and pull_request to branches: [ master ].

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or

  • This workflow must not send data to any 3rd party service except for the purposes of installing dependencies.

  • This workflow must not use a paid service or product.

jimhester and others added 3 commits October 16, 2019 13:17
This adds a workflow for [R packages](https://www.r-project.org/). It
uses a [setup-r](https://github.com/r-lib/actions/tree/master/setup-r) action and two R packages
  - [remotes](https://remotes.r-lib.org/) - to install the R package dependencies
  - [rcmdcheck](https://github.com/r-lib/rcmdcheck) - to run and format the output of the package checking tool used in the R ecosystem.
Copy link

@jquorning jquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that description is changed into "Build Ada project with GPRbuild."

@mosteo
Copy link
Contributor Author

mosteo commented May 25, 2020

Thanks for the review, @jquorning. I've pushed your suggested fix.

ci/ada.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@andymckay andymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mosteo and sorry for the delay. The workflow looks good, I left one suggestion to cope with $default-branch that we can change.

I'm unclear about the SVG logo you added though. It looks like a logo from Awesome Ada and not the a logo for Ada, which would confuse users. We also need a logo to be able to redistributed under the MIT license and I can't spot anything about that logo.

So we'd need to change this to the Ada logo with a link to something showing we can redistribute it.

mosteo and others added 2 commits August 24, 2020 11:10
@mosteo
Copy link
Contributor Author

mosteo commented Aug 24, 2020

Hello Andy,

Thanks @mosteo and sorry for the delay. The workflow looks good, I left one suggestion to cope with $default-branch that we can change.

Thanks for the suggestion, I just applied it.

I'm unclear about the SVG logo you added though. It looks like a logo from Awesome Ada and not the a logo for Ada, which would confuse users. We also need a logo to be able to redistributed under the MIT license and I can't spot anything about that logo.

Right, I did privately ask the Awesome Ada author for permission to use the logo but I see your points.

It seems the Hummingbird logo is the one used by the GNAT compiler people. According to that page, the Ada mascot can be freely used for anything Ada-related. Also, Wikipedia's version is explicitly Public Domain. I used that one and removed the text (since I see most icons avoid it). I just committed it.

Copy link
Contributor

@andymckay andymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @mosteo 👍🏾

@andymckay andymckay changed the base branch from master to main August 24, 2020 15:37
@andymckay andymckay merged commit 3ba9eeb into actions:main Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants